Visitar URL original
perf: Fix to nanomsg performance by sampsongao · Pull Request #120 · nodejs/abi-stable-node · GitHub
Skip to content

perf: Fix to nanomsg performance - #120

Closed
sampsongao wants to merge 1 commit into
nodejs:api-prototype-8.xfrom
sampsongao:api-prototype-8.x
Closed

perf: Fix to nanomsg performance#120
sampsongao wants to merge 1 commit into
nodejs:api-prototype-8.xfrom
sampsongao:api-prototype-8.x

Conversation

@sampsongao

@sampsongao sampsongao commented Mar 1, 2017

Copy link
Copy Markdown
Collaborator

No description provided.

@sampsongao sampsongao mentioned this pull request Mar 1, 2017
Closed
mhdawson

This comment was marked as off-topic.

Sign in to view

@jasongin

jasongin commented Mar 2, 2017

Copy link
Copy Markdown
Member

Note the entire node-api-helpers.h header file should be obsoleted by abi-stable-node-wrapper. We should update our ported code to use that eventually; if there's any issue with that then it should be improved accordingly.

@aruneshchandra

aruneshchandra commented Mar 9, 2017

Copy link
Copy Markdown
Contributor

Not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhdawson mhdawson mhdawson left review comments
+1 more reviewer
@kkoopa kkoopa kkoopa left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sampsongao @jasongin @aruneshchandra @kkoopa @mhdawson