Visitar URL original
buffer: add buf.mask for ws by chrisdickinson · Pull Request #1202 · nodejs/node · GitHub
Skip to content

buffer: add buf.mask for ws #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisdickinson wants to merge 8 commits into from
Closed

buffer: add buf.mask for ws #1202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
914dc46
initial commit
chrisdickinson Mar 19, 2015
3e425fc
rework to adhere more closely to buf.copy
chrisdickinson Mar 19, 2015
7bf9a2d
test style fixes
chrisdickinson Mar 19, 2015
e92f4b7
fixup whitespace
chrisdickinson Mar 19, 2015
7ef29ac
document and add rough tests for return value
chrisdickinson Mar 19, 2015
fb4ac8a
test: nix cleverness
chrisdickinson Mar 19, 2015
0f7b918
src: move to union to avoid pointer aliasing
chrisdickinson Mar 19, 2015
8c72550
src: fix style
chrisdickinson Mar 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
document and add rough tests for return value
  • Loading branch information
@chrisdickinson
chrisdickinson committed Mar 19, 2015
commit 7ef29aca42e02b7e2ed887d66daf88fc60e5832c
2 changes: 2 additions & 0 deletions doc/api/buffer.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,8 @@ corresponding parameters to

The target region of memory may overlap the source region of memory.

Returns the number of bytes masked and written into `targetBuffer`.

### buffer.values()

Creates iterator for buffer values (bytes). This function is called automatically
Expand Down
13 changes: 12 additions & 1 deletion test/parallel/test-buffer-mask.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ var tests = [
testBasic,
testBounds,
testOverflow,
testNonAligned
testNonAligned,
testReturnValue
]

tests.forEach(Function.prototype.call.bind(Function.prototype.call))

@bnoordhuis bnoordhuis Mar 19, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever... but a hell of a lot longer than tests.forEach(function(f) { f(); }) :-)

Minor style nit: missing semicolon.

Expand Down Expand Up @@ -79,3 +80,13 @@ function testNonAligned() {
assert.equal(output[i], refoutput[i]);
}
}

function testReturnValue() {
var input = new Buffer(16);
var output = new Buffer(16);
assert.equal(input.mask(0, output), 16)
assert.equal(input.mask(0, output, 4), 12)
assert.equal(input.mask(0, output, 4, 6), 10)
assert.equal(input.mask(0, output, 4, 6, 4), 0)
assert.equal(input.mask(0, output, 4, 6, 8), 2)
}