Visitar URL original
tools: added support for notarytool for osx notarization by UlisesGascon · Pull Request #48701 · nodejs/node · GitHub
Skip to content

tools: added support for notarytool for osx notarization #48701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UlisesGascon wants to merge 15 commits into from
Closed

tools: added support for notarytool for osx notarization #48701

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
95ccc14
tools: limit MacOS notarization with gon to Xcode version < 13.0
UlisesGascon Jul 8, 2023
7cc24d8
tools: added basic support for notarytool
UlisesGascon Jul 8, 2023
dc63135
fix: typo
UlisesGascon Jul 8, 2023
43446db
chore: linting
UlisesGascon Jul 8, 2023
a25c08f
chore: linting
UlisesGascon Jul 8, 2023
6ef370b
chore: linting
UlisesGascon Jul 8, 2023
3b7c993
fix: update script credentials
UlisesGascon Sep 13, 2023
ec27e52
fix: update script xcode version evaluation
UlisesGascon Sep 14, 2023
9a6e60c
fix: simplification and linting errors
UlisesGascon Sep 14, 2023
0e96609
fix: typo in command name
UlisesGascon Sep 14, 2023
94ca883
fix: add notarization team id
UlisesGascon Sep 14, 2023
1e82540
fix: arguments order
UlisesGascon Sep 14, 2023
4cb6407
fix: environmental variables management
UlisesGascon Sep 15, 2023
639dcb3
Update tools/osx-notarize.sh
UlisesGascon Sep 19, 2023
076dbcb
doc: add TODOs for OSX Notarization next steps
UlisesGascon Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: linting
  • Loading branch information
@UlisesGascon
UlisesGascon committed Jul 8, 2023
commit 6ef370befa02653febfa7123705dc0dfd8ecd0ae
2 changes: 1 addition & 1 deletion tools/osx-notarize.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if [ -z "$NOTARIZATION_ID" ]; then
exit 0
fi

if [ $(echo "$xcode_version < 13.0" | bc) -eq 1 ]; then
if [ "$(echo "$xcode_version < 13.0" | bc)" -eq 1 ]; then
echo "Notarization process is done with gon."
set -x

Expand Down