Sandbox::https://github.com/nodejs/node/pull/49465

GeoffreyBooth · 2023-09-03T00:51:30Z

This PR refactors test/es-module/test-esm-loader-mock.mjs to use the new register and initialize APIs instead of globalPreload and setImportMetaCallback. I tried to preserve as much of the previous test as possible; all of the assertions from the earlier version are unchanged. This test passes both here, on main, and within #49144.

The largest addition to test-esm-loader-mock.mjs was code that just moved there from within the insideAppContext function in mock-loader.mjs.

@nodejs/loaders

nodejs-github-bot · 2023-09-03T01:00:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53699/

JakobJingleheimer

🙌 wow! we should use this before & after as a poster-child for register & initialize

…to__

nodejs-github-bot · 2023-09-04T12:56:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53719/

nodejs-github-bot · 2023-09-04T22:44:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53731/

nodejs-github-bot · 2023-09-05T00:12:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53732/

nodejs-github-bot · 2023-09-05T00:50:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53735/

nodejs-github-bot · 2023-09-05T01:13:42Z

Landed in 6a5394e

PR-URL: #49465 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#49465 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #49465 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs/node#49465 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

GeoffreyBooth added test Issues and PRs related to Node.js core tests and test infrastructure. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders. labels Sep 3, 2023

GeoffreyBooth requested review from JakobJingleheimer, aduh95 and bmeck September 3, 2023 00:51

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 3, 2023

GeoffreyBooth mentioned this pull request Sep 3, 2023

esm: remove globalPreload hook (superseded by initialize) #49144

Merged

GeoffreyBooth removed the needs-ci PRs that need a full CI run. label Sep 3, 2023

JakobJingleheimer approved these changes Sep 3, 2023

View reviewed changes

aduh95 reviewed Sep 3, 2023

View reviewed changes

aduh95 added the needs-ci PRs that need a full CI run. label Sep 3, 2023

aduh95 reviewed Sep 3, 2023

View reviewed changes

Comment thread test/es-module/test-esm-loader-mock.mjs Outdated

aduh95 reviewed Sep 3, 2023

View reviewed changes

Comment thread test/fixtures/es-module-loaders/mock-loader.mjs Outdated

aduh95 reviewed Sep 3, 2023

View reviewed changes

Comment thread test/fixtures/es-module-loaders/mock-loader.mjs Outdated

aduh95 reviewed Sep 3, 2023

View reviewed changes

Comment thread test/es-module/test-esm-loader-mock.mjs Outdated

GeoffreyBooth added 3 commits September 3, 2023 18:50

esm: refactor mocking test

3e846c4

Move setup code into fixture; avoid global; add JSON.stringify, __pro…

a12d520

…to__

Review notes

844fe45

aduh95 reviewed Sep 3, 2023

View reviewed changes

Comment thread test/es-module/test-esm-loader-mock.mjs Outdated

aduh95 reviewed Sep 3, 2023

View reviewed changes

Comment thread test/fixtures/es-module-loaders/mock.mjs Outdated

do not mutate import.meta, trailing commas, add doDrainPort back

d1bedb7

aduh95 force-pushed the refactor-mocking-test branch from bcb1837 to d1bedb7 Compare September 3, 2023 18:48

GeoffreyBooth commented Sep 3, 2023

View reviewed changes

Comment thread test/fixtures/es-module-loaders/mock-loader.mjs Outdated

Update test/fixtures/es-module-loaders/mock-loader.mjs

34cc279

aduh95 reviewed Sep 3, 2023

View reviewed changes

Comment thread test/fixtures/es-module-loaders/mock-loader.mjs Outdated

Update test/fixtures/es-module-loaders/mock-loader.mjs

7a58719

aduh95 approved these changes Sep 4, 2023

View reviewed changes

GeoffreyBooth removed the needs-ci PRs that need a full CI run. label Sep 4, 2023

GeoffreyBooth added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 4, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 4, 2023

aduh95 added the needs-ci PRs that need a full CI run. label Sep 4, 2023

GeoffreyBooth mentioned this pull request Sep 4, 2023

esm: refactor globalPreload tests #49493

Closed

github-actions Bot mentioned this pull request Sep 5, 2023

CI Reliability 2023-09-05 nodejs/reliability#656

Open

19 tasks

GeoffreyBooth added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 5, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 5, 2023

nodejs-github-bot merged commit 6a5394e into nodejs:main Sep 5, 2023

GeoffreyBooth deleted the refactor-mocking-test branch September 5, 2023 01:14

This was referenced Sep 6, 2023

CI Reliability 2023-09-06 nodejs/reliability#657

Open

CI Reliability 2023-09-07 nodejs/reliability#658

Open

CI Reliability 2023-09-08 nodejs/reliability#659

Open

CI Reliability 2023-09-09 nodejs/reliability#660

Open

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023

esm: refactor mocking test

f34bd15

PR-URL: #49465 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

This was referenced Sep 28, 2023

v20.7.1 proposal #49917

Closed

v20.8.0 proposal #49932

Merged

targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023

esm: refactor mocking test

3c9111e

PR-URL: nodejs#49465 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Nov 11, 2023

[v18.x] Backport most ESM and customization hook changes #50669

Closed

targos added the backported-to-v18.x label Nov 23, 2023

targos pushed a commit that referenced this pull request Nov 23, 2023

esm: refactor mocking test

d1f5514

PR-URL: #49465 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024

esm: refactor mocking test

cda5c71

PR-URL: nodejs/node#49465 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024

esm: refactor mocking test

6a0900a

PR-URL: nodejs/node#49465 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Conversation

GeoffreyBooth commented Sep 3, 2023

Uh oh!

nodejs-github-bot commented Sep 3, 2023

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 4, 2023

Uh oh!

nodejs-github-bot commented Sep 4, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants