Visitar URL original
deps: update ngtcp2 and nghttp3, update quic impls by jasnell · Pull Request #51291 · nodejs/node · GitHub
Skip to content

deps: update ngtcp2 and nghttp3, update quic impls - #51291

Closed
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:quic-part-9
Closed

deps: update ngtcp2 and nghttp3, update quic impls#51291
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:quic-part-9

Conversation

@jasnell

@jasnell jasnell commented Dec 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Updates the ngtcp2 and nghttp3 dependencies and various bits of code that rely on it.

@nodejs-github-bot

nodejs-github-bot commented Dec 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels Dec 26, 2023
@jasnell
jasnell marked this pull request as ready for review December 27, 2023 00:53
@jasnell
jasnell requested a review from Qard December 27, 2023 00:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig

anonrig commented Dec 27, 2023

Copy link
Copy Markdown
Member

I'll review this tomorrow 👍

gengjiawen
gengjiawen reviewed Dec 27, 2023
View reviewed changes
Comment thread deps/ngtcp2/ngtcp2.gyp Outdated
This was referenced Dec 27, 2023
Closed
Closed
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig reviewed Dec 27, 2023
View reviewed changes
Comment thread src/quic/session.cc Outdated
Comment thread src/quic/session.cc Outdated
Comment thread src/quic/session.cc Outdated
Comment thread src/quic/session.cc Outdated
Comment thread src/quic/session.cc Outdated
Comment thread src/quic/session.cc Outdated
Comment thread src/quic/session.h Outdated
Comment thread src/quic/tlscontext.cc Outdated
Comment thread src/quic/tlscontext.h Outdated
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Dec 27, 2023 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56565/ 💚

@jasnell jasnell added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. dependencies PRs that add, update, or configure Node.js dependencies. commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Dec 27, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 28, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51291
✔  Done loading data for nodejs/node/pull/51291
----------------------------------- PR info ------------------------------------
Title      deps: update ngtcp2 and nghttp3, update quic impls (#51291)
Author     James M Snell  (@jasnell)
Branch     jasnell:quic-part-9 -> nodejs:main
Labels     lib / src, author ready, needs-ci, quic, dependencies
Commits    2
 - deps: update ngtcp2 and nghttp3
 - quic: update quic impl to use latest ngtcp2/nghttp3
Committers 1
 - James M Snell 
PR-URL: https://github.com/nodejs/node/pull/51291
Reviewed-By: Stephen Belanger 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51291
Reviewed-By: Stephen Belanger 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: update ngtcp2 and nghttp3
   ⚠  - quic: update quic impl to use latest ngtcp2/nghttp3
   ℹ  This PR was created on Tue, 26 Dec 2023 23:30:04 GMT
   ✔  Approvals: 1
   ✔  - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/51291#pullrequestreview-1796691870
   ✘  This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval)
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-12-27T19:28:53Z: https://ci.nodejs.org/job/node-test-pull-request/56565/
- Querying data for job/node-test-pull-request/56565/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7352086887

@gengjiawen gengjiawen added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Dec 29, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 29, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51291
✔  Done loading data for nodejs/node/pull/51291
----------------------------------- PR info ------------------------------------
Title      deps: update ngtcp2 and nghttp3, update quic impls (#51291)
Author     James M Snell  (@jasnell)
Branch     jasnell:quic-part-9 -> nodejs:main
Labels     lib / src, author ready, needs-ci, quic, dependencies
Commits    2
 - deps: update ngtcp2 and nghttp3
 - quic: update quic impl to use latest ngtcp2/nghttp3
Committers 1
 - James M Snell 
PR-URL: https://github.com/nodejs/node/pull/51291
Reviewed-By: Stephen Belanger 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51291
Reviewed-By: Stephen Belanger 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 26 Dec 2023 23:30:04 GMT
   ✔  Approvals: 2
   ✔  - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/51291#pullrequestreview-1796691870
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/51291#pullrequestreview-1798809500
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-12-28T23:37:07Z: https://ci.nodejs.org/job/node-test-pull-request/56565/
- Querying data for job/node-test-pull-request/56565/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7355913366

@jasnell

jasnell commented Dec 29, 2023

Copy link
Copy Markdown
Member Author

Landed in 07f3df4...0bf1548

jasnell added a commit that referenced this pull request Dec 29, 2023
@jasnell
deps: update ngtcp2 and nghttp3
86ca72a 
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
jasnell added a commit that referenced this pull request Dec 29, 2023
@jasnell
quic: update quic impl to use latest ngtcp2/nghttp3
0bf1548 
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@jasnell jasnell closed this Dec 29, 2023
@zcbenz zcbenz mentioned this pull request Dec 30, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jasnell @RafaelGSS
deps: update ngtcp2 and nghttp3
e53cbb2 
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jasnell @RafaelGSS
quic: update quic impl to use latest ngtcp2/nghttp3
7ecf994 
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
@targos targos mentioned this pull request Jan 30, 2024
Closed
richardlau pushed a commit that referenced this pull request May 10, 2024
@jasnell @richardlau
deps: update ngtcp2 and nghttp3
28c0c78 
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau richardlau mentioned this pull request May 16, 2024
Merged
@targos targos mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments
@Qard Qard Qard approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@targos targos Awaiting requested review from targos
@tniessen tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. dependencies PRs that add, update, or configure Node.js dependencies. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell @nodejs-github-bot @anonrig @Qard @gengjiawen @richardlau