Visitar URL original
watch: track worker thread entry files in --watch mode by SudhansuBandha · Pull Request #62368 · nodejs/node · GitHub
Skip to content

watch: track worker thread entry files in --watch mode #62368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 8 commits into from
Apr 28, 2026
Merged

watch: track worker thread entry files in --watch mode #62368

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b06a7ca
watch: track worker entry files in watch mode
SudhansuBandha Mar 21, 2026
4a1bab7
test: add test coverage for worker entry files in --watch mode
SudhansuBandha Mar 21, 2026
c110e64
watch: track worker thread dependencies in --watch mode for cjs files
SudhansuBandha Mar 26, 2026
b449eb1
watch: track worker thread dependencies in --watch mode for esm modules
SudhansuBandha Mar 26, 2026
eb05454
watch: added tests for worker in -- watch mode to include worker file…
SudhansuBandha Mar 31, 2026
1d0d829
test: add watch mode coverage for worker threads and dependencies
SudhansuBandha Apr 2, 2026
662287e
test: reduce timer interval to 250ms for faster execution
SudhansuBandha Apr 6, 2026
8fa637a
watch: handled race conditions while relaying events from worker
SudhansuBandha Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
watch: added tests for worker in -- watch mode to include worker file… 
… and nested dependencies
  • Loading branch information
@SudhansuBandha
SudhansuBandha committed Apr 28, 2026
commit eb05454d8b73ca536671224219400ee76eb202ed
67 changes: 0 additions & 67 deletions test/parallel/test-watch-mode-worker.mjs
View file
Open in desktop

This file was deleted.

236 changes: 235 additions & 1 deletion test/sequential/test-watch-mode.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,4 +943,238 @@ process.on('message', (message) => {
await done();
}
});
});

it('should watch changes to worker - cjs', async () => {
const dir = tmpdir.resolve(`watch-worker-cjs-${Date.now()}`);
mkdirSync(dir);

Comment thread
SudhansuBandha marked this conversation as resolved.
Resolved
const worker = path.join(dir, 'worker.js');

writeFileSync(worker, `
console.log("worker running");
`);

const file = createTmpFile(`
const { Worker } = require('node:worker_threads');

const w = new Worker(${JSON.stringify(worker)});
w.on('exit', () => {
console.log('running');
Comment thread
SudhansuBandha marked this conversation as resolved.
Resolved
});
`, '.js', dir);

const { stderr, stdout } = await runWriteSucceed({
file,
watchedFile: worker,
});

assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout, [
'worker running',
'running',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
`Restarting ${inspect(file)}`,
'worker running',
'running',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);
});

it('should watch changes to worker dependencies - cjs', async () => {
const dir = tmpdir.resolve(`watch-worker-dep-cjs-${Date.now()}`);
mkdirSync(dir);

const dep = path.join(dir, 'dep.js');
const worker = path.join(dir, 'worker.js');

writeFileSync(dep, `
module.exports = 'dep v1';
`);

writeFileSync(worker, `
const dep = require('./dep.js');
console.log(dep);
`);

const file = createTmpFile(`
const { Worker } = require('node:worker_threads');

const w = new Worker(${JSON.stringify(worker)});
w.on('exit', () => {
console.log('running');
});
`, '.js', dir);

const { stderr, stdout } = await runWriteSucceed({
file,
watchedFile: dep,
});

assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout, [
'dep v1',
'running',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
`Restarting ${inspect(file)}`,
'dep v1',
'running',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);
});

it('should watch changes to nested worker dependencies - cjs', async () => {
const dir = tmpdir.resolve(`watch-worker-dep-cjs-${Date.now()}`);
mkdirSync(dir);

const subDep = path.join(dir, 'sub-dep.js');
const dep = path.join(dir, 'dep.js');
const worker = path.join(dir, 'worker.js');

writeFileSync(subDep, `
module.exports = 'sub-dep v1';
`);

writeFileSync(dep, `
const subDep = require('./sub-dep.js');
console.log(subDep);
module.exports = 'dep v1';
`);

writeFileSync(worker, `
const dep = require('./dep.js');
`);

const file = createTmpFile(`
const { Worker } = require('node:worker_threads');

const w = new Worker(${JSON.stringify(worker)});
w.on('exit', () => {
console.log('running');
});
`, '.js', dir);

const { stderr, stdout } = await runWriteSucceed({
file,
watchedFile: subDep,
});

assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout, [
'sub-dep v1',
'running',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
`Restarting ${inspect(file)}`,
'sub-dep v1',
'running',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);
});

it('should watch changes to worker - esm', async () => {
const dir = tmpdir.resolve(`watch-worker-esm-${Date.now()}`);
mkdirSync(dir);

const worker = path.join(dir, 'worker.mjs');

writeFileSync(worker, `
console.log("worker running");
`);

const file = createTmpFile(`
import { Worker } from 'node:worker_threads';
new Worker(new URL(${JSON.stringify(pathToFileURL(worker))}));
`, '.mjs', dir);

const { stderr, stdout } = await runWriteSucceed({
file,
watchedFile: worker,
});

assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout, [
'worker running',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
`Restarting ${inspect(file)}`,
'worker running',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);
});

it('should watch changes to worker dependencies - esm', async () => {
const dir = tmpdir.resolve(`watch-worker-dep-esm-${Date.now()}`);
mkdirSync(dir);

const dep = path.join(dir, 'dep.mjs');
const worker = path.join(dir, 'worker.mjs');

writeFileSync(dep, `
export default 'dep v1';
`);

writeFileSync(worker, `
import dep from ${JSON.stringify(pathToFileURL(dep))};
console.log(dep);
`);

const file = createTmpFile(`
import { Worker } from 'node:worker_threads';
new Worker(new URL(${JSON.stringify(pathToFileURL(worker))}));
`, '.mjs', dir);

const { stderr, stdout } = await runWriteSucceed({
file,
watchedFile: dep,
});

assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout, [
'dep v1',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
`Restarting ${inspect(file)}`,
'dep v1',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);
});

it('should watch changes to nested worker dependencies - esm', async () => {
const dir = tmpdir.resolve(`watch-worker-dep-esm-${Date.now()}`);
mkdirSync(dir);

const subDep = path.join(dir, 'sub-dep.mjs');
const dep = path.join(dir, 'dep.mjs');
const worker = path.join(dir, 'worker.mjs');

writeFileSync(subDep, `
export default 'sub-dep v1';
`);

writeFileSync(dep, `
import subDep from ${JSON.stringify(pathToFileURL(subDep))};
console.log(subDep);
export default 'dep v1';
`);

writeFileSync(worker, `
import dep from ${JSON.stringify(pathToFileURL(dep))};
`);

const file = createTmpFile(`
import { Worker } from 'node:worker_threads';
new Worker(new URL(${JSON.stringify(pathToFileURL(worker))}));
`, '.mjs', dir);

const { stderr, stdout } = await runWriteSucceed({
file,
watchedFile: subDep,
});

assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout, [
'sub-dep v1',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
`Restarting ${inspect(file)}`,
'sub-dep v1',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);
});
});