Visitar URL original
fs: support caller-supplied readFile() buffers by mcollina · Pull Request #63634 · nodejs/node · GitHub
Skip to content

fs: support caller-supplied readFile() buffers #63634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jun 13, 2026
Merged

fs: support caller-supplied readFile() buffers #63634

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8edd28
fs: support caller-supplied readFile() buffers
mcollina May 29, 2026
adab9ee
fs: address PR review comments
mcollina Jun 10, 2026
ce65c0b
test: remove getBuffer tests
mcollina Jun 10, 2026
e6c1949
doc: add Buffer import to examples to satisfy lint
mcollina Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: add Buffer import to examples to satisfy lint 
PR-URL: #63634
Signed-off-by: matteo <matteo@example.com>
  • Loading branch information
@mcollina
mcollina committed Jun 10, 2026
commit e6c1949c90e79f808c7addd6c6574e2a654aedab
6 changes: 6 additions & 0 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,7 @@ of the file.
An example using the `buffer` option with a pre-allocated buffer:

```mjs
import { Buffer } from 'node:buffer';
import { open } from 'node:fs/promises';

const file = await open('./some/file/to/read');
Expand All @@ -745,6 +746,7 @@ try {
An example using the `buffer` option with a function returning a buffer:

```mjs
import { Buffer } from 'node:buffer';
import { open } from 'node:fs/promises';

const file = await open('./some/file/to/read');
Expand Down Expand Up @@ -1902,6 +1904,7 @@ Any specified {FileHandle} has to support reading.
An example using the `buffer` option with a pre-allocated buffer:

```mjs
import { Buffer } from 'node:buffer';
import { readFile } from 'node:fs/promises';

const buf = Buffer.alloc(16384);
Expand All @@ -1912,6 +1915,7 @@ console.log(contents); // A view over `buf` containing only the bytes read
An example using the `buffer` option with a function returning a buffer:

```mjs
import { Buffer } from 'node:buffer';
import { readFile } from 'node:fs/promises';

const contents = await readFile('/path/to/file', {
Expand Down Expand Up @@ -4420,6 +4424,7 @@ system requests but rather the internal buffering `fs.readFile` performs.
An example using the `buffer` option with a pre-allocated buffer:

```mjs
import { Buffer } from 'node:buffer';
import { readFile } from 'node:fs';

const buf = Buffer.alloc(16384);
Expand All @@ -4432,6 +4437,7 @@ readFile('/path/to/file', { buffer: buf }, (err, data) => {
An example using the `buffer` option with a function returning a buffer:

```mjs
import { Buffer } from 'node:buffer';
import { readFile } from 'node:fs';

readFile('/path/to/file', {
Expand Down
Loading