Visitar URL original
crypto: improve argument validation and error messages by panva · Pull Request #64852 · nodejs/node · GitHub
Skip to content

crypto: improve argument validation and error messages #64852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 4 commits into from
Closed

crypto: improve argument validation and error messages #64852

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e62e1d
crypto: fix Argon2 validation errors
panva Jul 28, 2026
97a7d92
crypto: validate key generation options
panva Jul 28, 2026
f5df725
crypto: reuse X509 issuer result
panva Jul 28, 2026
3eebfb7
crypto: clarify missing cipher error
panva Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
crypto: reuse X509 issuer result 
Avoid a second native call when reading the issuer certificate.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
  • Loading branch information
@panva
panva committed Jul 30, 2026
commit f5df7253fe821d3bb0c4272002789a3f39aa7e9e
2 changes: 1 addition & 1 deletion lib/internal/crypto/x509.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ class X509Certificate {
if (value === undefined) {
const cert = this[kHandle].getIssuerCert();
if (cert)
value = new InternalX509Certificate(this[kHandle].getIssuerCert());
value = new InternalX509Certificate(cert);
this[kInternalState].set('issuerCertificate', value);
}
return value;
Expand Down