Repository navigation
test_runner: log coverage report generation time - #66577
Open
joao-oliveira-softtor wants to merge 2 commits into
Open
joao-oliveira-softtor wants to merge 2 commits into
joao-oliveira-softtor wants to merge 2 commits into
Conversation
Measure coverage summary generation with the existing debug timer so NODE_DEBUG=test_runner can help diagnose slow coverage reports. End the timer when summary generation throws and retain the existing cleanup. Add subprocess tests for both isolation modes, disabled logging and coverage, and summary failure with real cleanup. Refs: nodejs#55103 Assisted-by: a coding agent Signed-off-by: João Victor <joao.oliveira@softtor.com.br>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
|
Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66577 +/- ##
==========================================
+ Coverage 90.43% 90.44% +0.01%
==========================================
Files 791 791
Lines 276488 276570 +82
Branches 53097 53124 +27
==========================================
+ Hits 250029 250132 +103
+ Misses 16855 16837 -18
+ Partials 9604 9601 -3
🚀 New features to boost your workflow:
|
Register node.test_runner in the static Perfetto category registry. The coverage timer queries this category even when NODE_DEBUG is unset, and Perfetto aborts when the category is not registered. Refs: nodejs#55103 Assisted-by: a coding agent Signed-off-by: João Victor <joao.oliveira@softtor.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
NODE_DEBUG=test_runnertimer aroundcoverage.summary()to helpdiagnose slow coverage reports, as suggested in #55103.
The timer ends even when summary generation throws, preserving existing
error handling and cleanup. It excludes test execution, reporter output,
and cleanup.
Tests
Added subprocess tests covering:
processandnoneisolation modes.Local validation on Linux: all seven new scenarios, seven targeted
coverage test files, and JavaScript lint passed. The full test suite
and cross-platform CI have not been run.
AI assistance
Codex assisted with implementation, tests, and automated verification.
Refs: #55103