Visitar URL original
doc: reserve NMV 154 for Electron 46 by dsanders11 · Pull Request #66712 · nodejs/node · GitHub
Skip to content

doc: reserve NMV 154 for Electron 46 - #66712

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dsanders11:patch-2
Oct 16, 2026
Merged

doc: reserve NMV 154 for Electron 46#66712
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dsanders11:patch-2

Conversation

@dsanders11

@dsanders11 dsanders11 commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reserving NMV 154 for Electron 46.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 13, 2026
@dsanders11 dsanders11 mentioned this pull request Oct 13, 2026
Merged
1 task done
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 13, 2026
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 14, 2026
@richardlau richardlau mentioned this pull request Oct 14, 2026
Closed
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 15, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

⚠ This PR has conflicts that must be resolved

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
�[36m⠋�[39m Loading data for nodejs/node/pull/66712
�[36m⠋�[39m Loading data for nodejs/node/pull/66712
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66712
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66712
�[36m⠋�[39m Getting comments from nodejs/node/pull/66712
�[36m⠋�[39m Getting commits from nodejs/node/pull/66712
✔  Done loading data for nodejs/node/pull/66712
----------------------------------- PR info ------------------------------------
Title      doc: reserve NMV 153 for Electron 46 (#66712)
Author     David Babenko-Sanders <dsanders11@ucsbalum.com> (@dsanders11)
Branch     dsanders11:patch-2 -> nodejs:main
Labels     doc, author ready, commit-queue
Commits    1
 - doc: reserve NMV 153 for Electron 46
Committers 1
 - David Sanders <dsanders11@ucsbalum.com>
PR-URL: https://github.com/nodejs/node/pull/66712
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66712
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 13 Oct 2026 20:32:27 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/66712#pullrequestreview-5509698816
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/66712#pullrequestreview-5509890440
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/66712#pullrequestreview-5510014131
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/66712#pullrequestreview-5523804091
   ⚠  This PR has conflicts that must be resolved
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@dsanders11 dsanders11 changed the title doc: reserve NMV 153 for Electron 46 doc: reserve NMV 154 for Electron 46 Oct 15, 2026
@dsanders11

dsanders11 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

I've switched this to reserving 154 instead of 153 since #66601 landed and took 153.

@richardlau, could you add the commit-queue PRs queued for automated landing through the Commit Queue. label again? Thanks!

@dsanders11
doc: reserve NMV 154 for Electron 46
49b9ab6 
Signed-off-by: David Babenko-Sanders <dsanders11@ucsbalum.com>
@richardlau richardlau added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 15, 2026
@richardlau richardlau removed the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Oct 15, 2026
@dsanders11

dsanders11 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Removed the earlier commit to prevent the commit history from being misleading, apologies for the churn.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 15, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: reserve NMV 154 for Electron 46
   ✖  GitHub CI is still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
�[36m⠋�[39m Loading data for nodejs/node/pull/66712
�[36m⠋�[39m Loading data for nodejs/node/pull/66712
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66712
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66712
�[36m⠋�[39m Getting comments from nodejs/node/pull/66712
�[36m⠋�[39m Getting commits from nodejs/node/pull/66712
✔  Done loading data for nodejs/node/pull/66712
----------------------------------- PR info ------------------------------------
Title      doc: reserve NMV 154 for Electron 46 (#66712)
Author     David Babenko-Sanders <dsanders11@ucsbalum.com> (@dsanders11)
Branch     dsanders11:patch-2 -> nodejs:main
Labels     doc, author ready, commit-queue
Commits    1
 - doc: reserve NMV 154 for Electron 46
Committers 1
 - David Sanders <dsanders11@ucsbalum.com>
PR-URL: https://github.com/nodejs/node/pull/66712
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66712
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: reserve NMV 154 for Electron 46
   ℹ  This PR was created on Tue, 13 Oct 2026 20:32:27 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/66712#pullrequestreview-5540882767
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/66712#pullrequestreview-5509890440
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/66712#pullrequestreview-5510014131
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/66712#pullrequestreview-5523804091
   ✖  GitHub CI is still running
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@richardlau richardlau added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 16, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 9df97a7 into nodejs:main Oct 16, 2026
22 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Landed in 9df97a7

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 16, 2026
@aduh95 aduh95 mentioned this pull request Oct 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb approved these changes
@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dsanders11 @nodejs-github-bot @bnb @lpinca @UlisesGascon @richardlau @aduh95