Visitar URL original
Properly parse set-cookie header using http2 by jeanp413 · Pull Request #2886 · nodejs/undici · GitHub
Skip to content

Properly parse set-cookie header using http2 - #2886

Merged
mcollina merged 2 commits into
nodejs:mainfrom
jeanp413:fix-http2-set-cookie-parse
Feb 29, 2024
Merged

mcollina merged 2 commits into
nodejs:mainfrom
jeanp413:fix-http2-set-cookie-parse

Conversation

@jeanp413

@jeanp413 jeanp413 commented Feb 29, 2024 •

Copy link
Copy Markdown
Contributor

This relates to...

Fixes #2885

Status

Comment thread lib/web/fetch/index.js Resolved

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the provided nit

@codecov-commenter

ghost commented Feb 29, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (3b2df8e) to head (af4134f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
- Coverage   93.80%   93.77%   -0.03%     
==========================================
  Files          85       85              
  Lines       23387    23395       +8     
==========================================
+ Hits        21938    21939       +1     
- Misses       1449     1456       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: tsctx <91457664+tsctx@users.noreply.github.com>
@mcollina
mcollina merged commit a3f494b into nodejs:main Feb 29, 2024
@jeanp413
jeanp413 deleted the fix-http2-set-cookie-parse branch February 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP/2 headers.getSetCookie returns array of arrays instead of array of strings

5 participants