Repository navigation
Conversation
berezucc
marked this pull request as draft
September 29, 2026 19:51
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
@berezucc Hi, Nikita! Thank you for taking the time to fill out the PR template. We’ll review the PR and follow up with any feedback by the next office hours. |
InessaPawson
reviewed
Oct 2, 2026
InessaPawson
left a comment
Member
There was a problem hiding this comment.
The proposed changes address the issue, so LGTM.
@berezucc One non-code request: please remove what looks like leftover placeholder text from the PR description: "Why you're interested: your own reason, for example the NumFOCUS program or your own use of NumPy".
Also, for future PRs, please take a little time to review your submission before requesting a review. Every PR to this project is reviewed by humans. Doing a thoughtful self-review first helps make the best use of everyone’s time.
InessaPawson
marked this pull request as ready for review
October 3, 2026 22:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
-Dcpu-baseline="none", will it still generate optimised code paths for newer CPUs? #31073First time contributor introduction
First time contributor here! I'm Nikita at Bloomberg, an engineer on our electronic trading team - previously an ML engineer at DRW and Shopify. Many of my ML and AI initiatives relied on NumPy for core numerical work, which is why I wanted to contribute back.
AI Disclosure