Visitar URL original
refactor: sort keys deeply by gr2m · Pull Request #261 · octokit/app-permissions · GitHub
Skip to content

refactor: sort keys deeply - #261

Merged
gr2m merged 4 commits into
mainfrom
resort-keys
Jan 30, 2025
Merged

refactor: sort keys deeply#261
gr2m merged 4 commits into
mainfrom
resort-keys

Conversation

@gr2m

@gr2m gr2m commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

in preparation of fixing the current update workflow to unblock actions/create-github-app-token#168

@github-actions

github-actions Bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339

wolfy1339 commented Jan 30, 2025

Copy link
Copy Markdown
Member

Is there supposed to be code here? So the order doesn't just change all the time

@gr2m

gr2m commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author

Is there supposed to be code here? So the order doesn't just change all the time

good point

@gr2m

gr2m commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author

done 👍🏼

@gr2m
gr2m merged commit a998087 into main Jan 30, 2025
@gr2m
gr2m deleted the resort-keys branch January 30, 2025 23:49
@wolfy1339

wolfy1339 commented Jan 30, 2025

Copy link
Copy Markdown
Member

Btw, I did have a stab at updating in #247

It's what I could figure out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gr2m @wolfy1339