Visitar URL original
[FSSDK-9486] chore: Prepare for releasing 3.11.3 by mikechu-optimizely · Pull Request #358 · optimizely/csharp-sdk · GitHub
Skip to content

[FSSDK-9486] chore: Prepare for releasing 3.11.3 - #358

Merged
Mike Chu (mikechu-optimizely) merged 7 commits into
release-3.11.3from
mike/prep-release-3-11-3
Jul 19, 2023
Merged

[FSSDK-9486] chore: Prepare for releasing 3.11.3#358
Mike Chu (mikechu-optimizely) merged 7 commits into
release-3.11.3from
mike/prep-release-3-11-3

Conversation

@mikechu-optimizely

@mikechu-optimizely Mike Chu (mikechu-optimizely) commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Summary

  • Increment semantic version number in assemblies
  • Update CHANGELOG

Test plan

  • Only release prep. No code paths changed.
  • All existing tests should continue to pass.

Issues

  • FSSDK-9472
  • FSSDK-9486

@mikechu-optimizely Mike Chu (mikechu-optimizely) mentioned this pull request Jul 3, 2023
Merged
@mikechu-optimizely

Mike Chu (mikechu-optimizely) commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

PRs #356 & #357 need to be merged into the release-branch before this one.

@mikechu-optimizely
Mike Chu (mikechu-optimizely) marked this pull request as ready for review July 18, 2023 17:53
@mikechu-optimizely
Mike Chu (mikechu-optimizely) requested a review from a team as a code owner July 18, 2023 17:53
jaeopt
Jae Kim (jaeopt) approved these changes Jul 18, 2023
View reviewed changes

@jaeopt Jae Kim (jaeopt) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - date in changelog should be updated

Comment thread CHANGELOG.md Resolved
@muzahidul-opti

Muzahidul Islam (muzahidul-opti) commented Jul 18, 2023 •
edited
Loading

Copy link
Copy Markdown

LGTM - Curious to know why fullstack check is failing.

@mikechu-optimizely

Mike Chu (mikechu-optimizely) commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

LGTM - Curious to know why fullstack check is failing.

Great catch Muzahidul Islam (@muzahidul-opti) I missed that because apparently I don't have the checks configured correctly. Let me look into both before continuing....

@mikechu-optimizely

Mike Chu (mikechu-optimizely) commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Oh wait, branch checks are configured for master and we're merging into release-3.11.3.

...but yeah why is optimizely/fullstack-sdk-compatibility-suite showing failure....hmmm

@mikechu-optimizely

Mike Chu (mikechu-optimizely) commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Found it.

I'm building SDK version 3.11.3, which does not have any coding for ATS/ODP. FSC is using end-to-end tests (csharp-testapp) that has ODP in play and expects the SDK to have the ODP classes so the build is failing

I need to think about how to use an older tag of the csharp-testapp that did not expect ODP to be present 🤔

Muzahidul Islam (@muzahidul-opti)

@mikechu-optimizely

Mike Chu (mikechu-optimizely) commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Grrr. Ok. TestApp built successfully using an older non-ODP version, but now FSC itself needs to be run using a version before adding ODP.

58 failing tests all appear to be ODP.

Muzahidul Islam (@muzahidul-opti) Jae Kim (@jaeopt)

@mikechu-optimizely

Mike Chu (mikechu-optimizely) commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Yasir Folio3 (@yasirfolio3) Is there a way to run FSC at a point before ODP tests?

@mikechu-optimizely

Mike Chu (mikechu-optimizely) commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Thanks
Yasir Folio3 (@yasirfolio3) for pointing me in the direction of passing e2e testing for non ODP C#
Muzahidul Islam (@muzahidul-opti) for catching my oversight on e2e
Jae Kim (@jaeopt) for your 3 reviews to get this out the door.

@mikechu-optimizely
Mike Chu (mikechu-optimizely) merged commit 97b240a into release-3.11.3 Jul 19, 2023
@mikechu-optimizely
Mike Chu (mikechu-optimizely) deleted the mike/prep-release-3-11-3 branch July 19, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt Jae Kim (jaeopt) jaeopt approved these changes

Assignees

@mikechu-optimizely Mike Chu (mikechu-optimizely)

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikechu-optimizely @muzahidul-opti @jaeopt