Repository navigation
refactor: simplify Target and Remote layering - #2333
Open
Hrushikesh-ramilla wants to merge 1 commit into
Open
Hrushikesh-ramilla wants to merge 1 commit into
Hrushikesh-ramilla wants to merge 1 commit into
Conversation
Signed-off-by: hrushikeshramilla <ramillahrushikesh@gmail.com>
Hrushikesh-ramilla
requested review from
TerryHowe,
Wwwsylvia,
sabre1041,
sajayantony and
shizhMSFT
as code owners
November 12, 2026 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Simplifies the
Target/Remotelayering incmd/oras/internal/option:Target.ModifyErrorontarget.Type == TargetTypeOCILayout || target.IsOCILayoutso--oci-layout-pathtargets do not fall through into remote registry error formatting.Target.prefixfield and usesRemote.flagPrefixconsistently acrosssetFlagDetails,ApplyFlags, andParse.TargetTypeOCILayout/TargetTypeRemotedispatch acrossNewTarget,NewBlobDeleter,NewManifestDeleter, andNewReadonlyTarget.remo.storeon demand viacredentialStore()soRemote.ConfigPath()andDecorateCredentialError()do not depend onauthClienthaving run first.Which issue(s) this PR fixes:
Relates to #2280
Please check the following list: