Visitar URL original

[DC-156] fix: system tray cleanup by DeepDiver1975 · Pull Request #12301 · owncloud/client · GitHub

Repository navigation

[DC-156] fix: system tray cleanup - #12301

Merged

modSpike merged 13 commits into

fix/context-menu-flickering-2

Sep 12, 2025

Merged

[DC-156] fix: system tray cleanup#12301
modSpike merged 13 commits into
masterfrom
fix/context-menu-flickering-2

DeepDiver1975 commented Sep 10, 2025

Contributor

No description provided.

DeepDiver1975 added 2 commits

September 10, 2025 16:30


          chore: remove systray context menu workarounds

7e7e837


          fix: drop status menu item from system tray menu

ebbe6c4

update-docs Bot commented Sep 10, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

DeepDiver1975 marked this pull request as draft

September 10, 2025 14:43

DeepDiver1975 changed the title ~~fix: system try cleanup~~ fix: system tray cleanup

DeepDiver1975 added 6 commits

September 10, 2025 16:57


          fix: remove "recent changes" from systray menu

8a41703


          fix: remove accounts from system tray menu

3ccff36


          fix: remove timer to update system tray menu

c7dec65


          fix: remove global sync handling form system tray menu

9aeef6b


          fix: cut all dynamic processing from the system tray menu

2bdd09a


          fix: remove system tray tool tips

cdc78e7

DeepDiver1975 force-pushed the fix/context-menu-flickering-2 branch from cd53ca7 to cdc78e7 Compare

September 10, 2025 16:24

DeepDiver1975 added 2 commits

September 11, 2025 09:55


          fix: drop ProgressDispatcher and slots for account updates - we only …

737b49a

…need to react to updates on folder basis


          fix: cleanup tray status computation and bring back account status no…

641e73c

…tification

DeepDiver1975 marked this pull request as ready for review

September 11, 2025 10:46

DeepDiver1975 requested review from erikjv and modSpike

September 11, 2025 10:46

DeepDiver1975 commented

View reviewed changes

src/gui/folderman.cpp Resolved

modSpike reviewed

View reviewed changes

src/gui/owncloudgui.h Resolved

modSpike reviewed

View reviewed changes

src/gui/owncloudgui.h Resolved

DeepDiver1975 commented

View reviewed changes

src/gui/owncloudgui.cpp Resolved


          chore: fixing comments and remove [[nodiscard]]

36c26b9

erikjv previously approved these changes

View reviewed changes

modSpike reviewed

View reviewed changes

src/gui/owncloudgui.h Resolved

modSpike reviewed

View reviewed changes

src/gui/owncloudgui.h Resolved

modSpike reviewed

View reviewed changes

src/gui/owncloudgui.h Resolved

modSpike reviewed

View reviewed changes

src/gui/owncloudgui.cpp Resolved

modSpike reviewed

View reviewed changes

src/gui/owncloudgui.h Resolved

modSpike requested changes

View reviewed changes

modSpike left a comment

Contributor

see comments but overall an OUTSTANDING cleanup!

DeepDiver1975 dismissed erikjv’s stale review via

a1181e8

September 11, 2025 22:07


          fix: adust constness and naming

33d0148

DeepDiver1975 force-pushed the fix/context-menu-flickering-2 branch from a1181e8 to 33d0148 Compare

September 12, 2025 08:47

DeepDiver1975 changed the title ~~fix: system tray cleanup~~ [DC-156] fix: system tray cleanup

modSpike approved these changes

View reviewed changes


          Merge branch 'master' into fix/context-menu-flickering-2

26edf77

modSpike enabled auto-merge (squash)

September 12, 2025 10:14

modSpike merged commit a7b7f9b into master

modSpike deleted the fix/context-menu-flickering-2 branch

September 12, 2025 10:30

DeepDiver1975 mentioned this pull request

Menu item artifact #11995

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet