Visitar URL original
Remove dav.enable.tech_preview by phil-davis · Pull Request #36815 · owncloud/core · GitHub
Skip to content

Remove dav.enable.tech_preview - #36815

Merged
micbar merged 4 commits into
masterfrom
remove-tech_preview
Jan 24, 2020
Merged

Remove dav.enable.tech_preview#36815
micbar merged 4 commits into
masterfrom
remove-tech_preview

Conversation

@phil-davis

@phil-davis phil-davis commented Jan 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Make the new trashbin API and new public links API available by default.

  • remove dav.enable.tech_preview setting/logic from source code and config.sample.php
  • only do the dav.enable.tech_preview logic in tests when testing against an older version (e.g. we run core tests from apps against "latest" core release = 10.3.2)
  • do not bother setting dav.enable.tech_preview for litmus tests in drone
  • remove now-irrelevant tests that checked behaviour when dav.enabled.tech_preview was off (we don't really care about re-engineering them so that they will still run when testing against 10.3.2)

Related doc PR owncloud/docs#2248

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jan 23, 2020
@micbar micbar changed the title Remove dav.enable.tech_preview [OC-8] Remove dav.enable.tech_preview Jan 23, 2020
@codecov

codecov Bot commented Jan 23, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #36815 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36815      +/-   ##
============================================
+ Coverage     64.68%   64.69%   +<.01%     
+ Complexity    19122    19117       -5     
============================================
  Files          1269     1269              
  Lines         74779    74774       -5     
  Branches       1320     1320              
============================================
+ Hits          48373    48376       +3     
+ Misses        26018    26010       -8     
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.86% <88.88%> (ø) 19117 <0> (-5) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Capabilities.php 0% <0%> (ø) 3 <0> (-1) ⬇️
apps/dav/lib/RootCollection.php 100% <100%> (+8.1%) 1 <0> (-2) ⬇️
apps/dav/lib/Server.php 51.28% <100%> (+0.01%) 20 <0> (-2) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76d5b2...c3443df. Read the comment docs.

@owncloud owncloud deleted a comment from update-docs Bot Jan 23, 2020
@mmattel mmattel mentioned this pull request Jan 23, 2020
Closed
2 of 12 tasks
phil-davis
phil-davis commented Jan 24, 2020
View reviewed changes
Comment thread tests/acceptance/features/bootstrap/OccContext.php
$ocVersion = SetupHelper::getSystemConfigValue('version');
// dav.enable.tech_preview was used in some ownCloud versions before 10.4.0
// only set it on those versions of ownCloud
if (\version_compare($ocVersion, '10.4.0') === -1) {

@phil-davis phil-davis Jan 24, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I checked this locally to make sure we do not go down this path on the current core 10.4.0.1 version, and will go down this path on 10.3.*

@phil-davis phil-davis mentioned this pull request Jan 24, 2020
Merged
individual-it
individual-it reviewed Jan 24, 2020
View reviewed changes

@individual-it individual-it left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look good to me

@phil-davis

phil-davis commented Jan 24, 2020

Copy link
Copy Markdown
Contributor Author

@micbar the backend code changes are very simple. Artur has reviewed the test code changes.
Maybe you can review/approve/merge this? Otherwise please allocate somebody.

@micbar micbar changed the title [OC-8] Remove dav.enable.tech_preview Remove dav.enable.tech_preview Jan 24, 2020
@micbar
micbar merged commit 63e2556 into master Jan 24, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the remove-tech_preview branch January 24, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it left review comments
+1 more reviewer
@micbar micbar micbar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@phil-davis phil-davis

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phil-davis @individual-it @micbar