Visitar URL original
fix: CalDAV query with time range not being an array by DeepDiver1975 · Pull Request #41050 · owncloud/core · GitHub
Skip to content

fix: CalDAV query with time range not being an array - #41050

Merged
DeepDiver1975 merged 1 commit into
masterfrom
fix/caldav-timerange-false
Oct 17, 2023
Merged

fix: CalDAV query with time range not being an array#41050
DeepDiver1975 merged 1 commit into
masterfrom
fix/caldav-timerange-false

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Oct 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs

update-docs Bot commented Oct 17, 2023

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975
DeepDiver1975 force-pushed the fix/caldav-timerange-false branch from d3287d7 to db8cc9e Compare October 17, 2023 08:28
@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 17, 2023
Closed
@DeepDiver1975
DeepDiver1975 force-pushed the fix/caldav-timerange-false branch from db8cc9e to dc5449d Compare October 17, 2023 09:00
@DeepDiver1975
DeepDiver1975 force-pushed the fix/caldav-timerange-false branch from dc5449d to 79f39f7 Compare October 17, 2023 09:02
phil-davis
phil-davis reviewed Oct 17, 2023
View reviewed changes
Comment thread apps/dav/tests/unit/CalDAV/CalDavBackendTest.php Resolved
jvillafanez
jvillafanez approved these changes Oct 17, 2023
View reviewed changes

@jvillafanez jvillafanez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the typo, the code looks good

@DeepDiver1975
DeepDiver1975 force-pushed the fix/caldav-timerange-false branch 2 times, most recently from c69da41 to 79f39f7 Compare October 17, 2023 12:46
@sonarqubecloud

sonarqubecloud Bot commented Oct 17, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@DeepDiver1975
DeepDiver1975 merged commit 87e6c64 into master Oct 17, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the fix/caldav-timerange-false branch October 17, 2023 18:46
@rainforest1155

rainforest1155 commented Oct 17, 2023 •
edited
Loading

Copy link
Copy Markdown

@DeepDiver1975 Is it just me or did the typo @jvillafanez seems to have pointed out is merged?
I think it’s line 405 where I see:
'timernage false' => [[0, 1, 2, 3], [], [['name' => 'VEVENT', 'is-not-defined' => false, 'comp-filters' => [], 'time-range' => false, 'prop-filters' => []]],],

timernage looks very much like a typo to me.

@DeepDiver1975

DeepDiver1975 commented Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

Indeed something got mixed up here..... Damn ....

@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 18, 2023
Merged
1 of 11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis left review comments
@jvillafanez jvillafanez jvillafanez approved these changes

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trying to access array offset on value of type bool at CalDavBackend.php#996

4 participants

@DeepDiver1975 @rainforest1155 @jvillafanez @phil-davis