Visitar URL original
feat: issue forms & developer guide by DeepDiver1975 · Pull Request #2 · owncloud/developer-certificates · GitHub
Skip to content

feat: issue forms & developer guide - #2

Merged
DeepDiver1975 merged 2 commits into
mainfrom
feat/issue-forms-and-docs
Jul 7, 2026
Merged

DeepDiver1975 merged 2 commits into
mainfrom
feat/issue-forms-and-docs

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Contributor

What & why

Second of the initial PR set: the GitHub issue intake forms and the external
developer documentation. Implements the developer-documentation spec
(docs/specs/2026-07-06-spec-developer-documentation.md) §7 (forms) and §1–§10
(guide), plus the intake config.yml.

Built test-first — the two commits show the TDD loop:

  1. test: — conformance harness asserting the invariants (fails, red).
  2. feat: — the artifacts that satisfy them (passes, green).

Artifacts

  • .github/ISSUE_TEMPLATE/certificate-request.yml — CSR + repo, two required
    fields (spec §7.1).
  • .github/ISSUE_TEMPLATE/revocation-request.yml — signed self-service
    revocation (spec §7.2).
  • .github/ISSUE_TEMPLATE/config.yml — blank issues disabled; abuse / lost-key
    reports routed to the Security Advisory (VDP) (design §7.1 case 3).
  • docs/developer-guide.md — external developer guide.

Conformance invariants pinned (test/forms_test.go)

  • Both forms parse; cert-request has exactly two required inputs + label
    cert-request; revocation-request has cert + signed_request + label
    revocation-request.
  • The security-critical appId regex ^[a-z][a-z0-9_-]{1,63}$ (design §4.1)
    appears in the form and the guide (must not drift).
  • The challenge path /.well-known/owncloud-codesigning-challenge.txt (§5.3)
    appears in the guide.
  • No unresolved <codesigning-repo> placeholder in the guide.

Notes

  • <codesigning-repo> resolved to DeepDiver1975/developer-certificates.
  • The two spec-level TBDs — Mode-2 bind(H,T) token layout and the
    signed-revocation statement bytes — are surfaced in the guide as explicit
    "not yet finalized" notes rather than invented; they land with the attestation
    and revocation-bot PRs.

Checklist

  • Scoped to a single concern (forms + docs)
  • Spec sections referenced (docs/specs/…-developer-documentation.md)
  • test/ harness passes (cd test && go test ./...)
  • No workflow changes (SHA-pinning already in place)
  • Commits DCO signed-off and signed

🤖 Generated with Claude Code

DeepDiver1975 and others added 2 commits July 7, 2026 11:31
Test-first: assert the security-critical invariants before the artifacts exist.

- certificate-request.yml: exactly two required inputs (csr textarea, repo
  input), label cert-request, appId regex present.
- revocation-request.yml: cert input + signed_request textarea, label
  revocation-request.
- config.yml: blank issues disabled, Security Advisory (VDP) contact link.
- developer-guide.md: appId regex (§4.1) and challenge path (§5.3) present,
  no unresolved <codesigning-repo> placeholder.

These fail now (artifacts land in the next commit) — proving the red→green loop.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Land the artifacts that satisfy the conformance harness:

- .github/ISSUE_TEMPLATE/certificate-request.yml — CSR + repo intake form
  (dev-doc spec §7.1).
- .github/ISSUE_TEMPLATE/revocation-request.yml — signed self-service
  revocation form (dev-doc spec §7.2).
- .github/ISSUE_TEMPLATE/config.yml — blank issues disabled; abuse / lost-key
  reports routed to the Security Advisory (VDP) per design §7.1 case 3.
- docs/developer-guide.md — external developer documentation (dev-doc spec
  §1–§10), with <codesigning-repo> resolved to DeepDiver1975/developer-certificates.
  The two spec-level TBDs (Mode-2 bind(H,T) layout; signed-revocation statement
  bytes) are surfaced as explicit 'not yet finalized' notes, not invented.

All five conformance tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 merged commit b94af04 into main Jul 7, 2026
1 check passed
@DeepDiver1975
DeepDiver1975 deleted the feat/issue-forms-and-docs branch July 7, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant