Visitar URL original
Add CLI command to test Blobstore by kobergj · Pull Request #12102 · owncloud/ocis · GitHub
Skip to content

Add CLI command to test Blobstore - #12102

Merged
kobergj merged 2 commits into
owncloud:masterfrom
kobergj:TestBlobstoreCli
Mar 12, 2026
Merged

Add CLI command to test Blobstore#12102
kobergj merged 2 commits into
owncloud:masterfrom
kobergj:TestBlobstoreCli

Conversation

@kobergj

@kobergj kobergj commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Adds a cli command that allows to test the blobstore through GET, POST and DELETE requests.

@kobergj
feat: add cli command to test the blobstore
1d2c329 
Signed-off-by: Julian Koberg <julian.koberg@kiteworks.com>
@kobergj
kobergj requested a review from Copilot March 10, 2026 15:41
Copilot AI reviewed Mar 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new ocis storage-users blobstore CLI command group to help operators validate and inspect the configured blobstore for the storage-users service (ocis + s3ng drivers).

Changes:

  • Registers a new blobstore command group with check (round-trip upload/download/delete) and get (fetch by blob/space ID or parsed path).
  • Implements blobstore initialization based on existing service configuration for ocis and s3ng drivers.
  • Documents the new commands in the storage-users README and adds an unreleased changelog entry.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
services/storage-users/pkg/command/root.go Wires the new blobstore command group into the storage-users CLI.
services/storage-users/pkg/command/blobstore.go Implements blobstore CLI commands and helpers (path parsing, round-trip check, single-blob fetch).
services/storage-users/README.md Adds operator-facing docs and examples for blobstore check/get.
changelog/unreleased/enhancement-storage-users-blobstore-cli.md Records the enhancement in the changelog.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread services/storage-users/pkg/command/blobstore.go Resolved
Comment thread services/storage-users/README.md Resolved
Comment thread services/storage-users/pkg/command/blobstore.go Resolved
Comment thread services/storage-users/pkg/command/blobstore.go Resolved
Comment thread services/storage-users/pkg/command/blobstore.go Resolved
@kobergj
kobergj requested a review from Copilot March 10, 2026 16:06
Copilot AI reviewed Mar 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread services/storage-users/pkg/command/blobstore.go Resolved
Comment thread services/storage-users/pkg/command/blobstore.go Resolved
@kobergj
fix: adjust to comments from CR
15b1c38 
Signed-off-by: Julian Koberg <julian.koberg@kiteworks.com>
@mmattel

mmattel commented Mar 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Q: for option --blob-id you need to provide a value. How to get/know the value? We have a process (described in the admin docs for the space-id, so I am curios how this is for the blob-id.

@mmattel mmattel mentioned this pull request Mar 11, 2026
Closed
@sonarqubecloud

sonarqubecloud Bot commented Mar 11, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
9.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kobergj
kobergj merged commit dd99e6d into owncloud:master Mar 12, 2026
5 checks passed
@kobergj
kobergj deleted the TestBlobstoreCli branch March 12, 2026 07:27
ownclouders pushed a commit that referenced this pull request Mar 12, 2026
@kobergj
Merge pull request #12102 from kobergj/TestBlobstoreCli
7b41545 
Add CLI command to test Blobstore
@ghost ghost mentioned this pull request Jun 1, 2026
Closed
@ishabaral ishabaral mentioned this pull request Jun 26, 2026
Open
14 of 16 tasks
@anon-pradip anon-pradip mentioned this pull request Jul 6, 2026
Merged
2 of 9 tasks
@mmattel mmattel mentioned this pull request Jul 14, 2026
Closed
@ishabaral ishabaral mentioned this pull request Jul 22, 2026
Closed
@DeepDiver1975 DeepDiver1975 mentioned this pull request Aug 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@2403905 2403905 2403905 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kobergj @mmattel @2403905