Visitar URL original
[tests-only] add e2e test for app json viewer by nabim777 · Pull Request #142 · owncloud/web-extensions · GitHub
Skip to content

[tests-only] add e2e test for app json viewer - #142

Merged
nabim777 merged 1 commit into
mainfrom
tests/app-json-viewer
Mar 11, 2025
Merged

[tests-only] add e2e test for app json viewer#142
nabim777 merged 1 commit into
mainfrom
tests/app-json-viewer

Conversation

@nabim777

@nabim777 nabim777 commented Feb 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

In this PR, an e2e test is added for the web-app-json-viewer extension.

steps added:

  • upload json file jsonFile.json
  • view json file

Test run command

pnpm test:e2e --project='json-viewer-chromium'

For more details on how to run the test, please refer to the link here.

Related Issue

Screenshots (if appropriate):

Following video shows what's automated in the E2E test for web-app-json-viewer extension (added in this PR)

Screencast.from.02-18-2025.12.41.28.PM.webm

How Has This Been Tested?

  • test environment:
  • CI
  • locally
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777
nabim777 force-pushed the tests/app-json-viewer branch 3 times, most recently from be0b031 to 750f445 Compare February 18, 2025 08:39
@nabim777 nabim777 self-assigned this Feb 18, 2025
@nabim777
nabim777 marked this pull request as ready for review February 18, 2025 08:45
@nabim777
nabim777 force-pushed the tests/app-json-viewer branch from 750f445 to 4563a67 Compare February 18, 2025 09:45
@nabim777 nabim777 mentioned this pull request Feb 20, 2025
Open
6 of 7 tasks
ghost
ghost reviewed Feb 25, 2025
View reviewed changes
Comment thread support/pages/filesPage.ts Outdated
prashant-gurung899
prashant-gurung899 reviewed Feb 25, 2025
View reviewed changes
Comment thread packages/web-app-json-viewer/tests/e2e/jsonViewer.spec.ts Outdated
@nabim777
nabim777 force-pushed the tests/app-json-viewer branch from 4563a67 to 2bb14c2 Compare February 25, 2025 06:58
@nabim777
nabim777 requested review from a user and prashant-gurung899 February 25, 2025 07:01
ghost
ghost reviewed Feb 25, 2025
View reviewed changes
Comment thread support/pages/filesPage.ts Outdated
@nabim777
nabim777 force-pushed the tests/app-json-viewer branch 2 times, most recently from db4931e to 3c72ed5 Compare March 5, 2025 07:48
@nabim777
nabim777 requested a review from a user March 5, 2025 08:30
amrita-shrestha
amrita-shrestha suggested changes Mar 10, 2025
View reviewed changes
Comment thread support/pages/filesPage.ts Outdated
@nabim777
add e2e test for app json viewer
962a1ac 
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777
nabim777 force-pushed the tests/app-json-viewer branch from 3c72ed5 to 962a1ac Compare March 10, 2025 10:45
amrita-shrestha
amrita-shrestha approved these changes Mar 10, 2025
View reviewed changes

@amrita-shrestha amrita-shrestha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@LukasHirt

LukasHirt commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator

@nabim777 can we merge this or is there anything still to be done?

@nabim777

nabim777 commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

@nabim777 can we merge this or is there anything still to be done?

Yes we can merge it @LukasHirt

@nabim777
nabim777 merged commit 456ae21 into main Mar 11, 2025
@nabim777
nabim777 deleted the tests/app-json-viewer branch March 11, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anon-pradip anon-pradip Awaiting requested review from anon-pradip
@saw-jan saw-jan Awaiting requested review from saw-jan
@S-Panta S-Panta Awaiting requested review from S-Panta
@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya
@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899
2 more reviewers
@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nabim777 nabim777

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nabim777 @LukasHirt @prashant-gurung899 @amrita-shrestha