Visitar URL original
test: add e2e tests to check cast file-action by saw-jan · Pull Request #186 · owncloud/web-extensions · GitHub
Skip to content

test: add e2e tests to check cast file-action - #186

Merged
saw-jan merged 6 commits into
mainfrom
test/e2e-cast-extension
May 30, 2025
Merged

test: add e2e tests to check cast file-action#186
saw-jan merged 6 commits into
mainfrom
test/e2e-cast-extension

Conversation

@saw-jan

@saw-jan saw-jan commented May 29, 2025 •
edited by deyankiteworks
Loading

Copy link
Copy Markdown
Member

JIRA: #OCISDEV-68

Added webUI e2e test to check the "Cast" file-action which is added by web-app-cast extension
Currently, the test is expected to fail as the extension doesn't work with firefox, webkit and headless chromium
See #187

Part of #118

saw-jan added 3 commits May 29, 2025 12:55
@saw-jan
ci: allow cast asset host
0148238 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan
test: add e2e test to check cast file-action
8df07a5 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan
test: mark test as fail
c2aed6f 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan saw-jan self-assigned this May 29, 2025
@saw-jan saw-jan mentioned this pull request May 28, 2025
Open
6 of 7 tasks
saw-jan
saw-jan commented May 29, 2025
View reviewed changes
Comment thread packages/web-app-cast/tests/e2e/castFileAction.spec.ts Resolved
@saw-jan
test: exclude e2e tests in unit test config
4f97a16 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@CLAassistant

CLAassistant commented May 29, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@saw-jan
ci: include e2e tests for cast extension
54cc66b 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
amrita-shrestha
amrita-shrestha suggested changes May 29, 2025
View reviewed changes

@amrita-shrestha amrita-shrestha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better if you added screencast of e2e tests. IT help viewer to grab idea what you are testing because all of us doesn't work much on web extension

Comment thread dev/docker/csp.yaml Resolved
Comment thread packages/web-app-cast/tests/e2e/castFileAction.spec.ts Resolved
Comment thread playwright.config.ts Resolved
@saw-jan

saw-jan commented May 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

better if you added screencast of e2e tests. IT help viewer to grab idea what you are testing because all of us doesn't work much on web extension

we only test the functionality of the extension. testing actual screen-casting is out of the scope (we won't test the third party features) and testing it might not be even possible with automation and headless browsers

@saw-jan
test: add issue comment docs
154e8cc 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan
saw-jan requested a review from amrita-shrestha May 29, 2025 10:07
@saw-jan saw-jan mentioned this pull request May 29, 2025
Merged
@saw-jan
saw-jan merged commit 521a5f0 into main May 30, 2025
@saw-jan
saw-jan deleted the test/e2e-cast-extension branch May 30, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anon-pradip anon-pradip Awaiting requested review from anon-pradip
@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899
@nabim777 nabim777 Awaiting requested review from nabim777
@deyankiteworks deyankiteworks Awaiting requested review from deyankiteworks
1 more reviewer
@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@saw-jan saw-jan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saw-jan @CLAassistant @amrita-shrestha