Visitar URL original
Add other input types for SQLAlchemy BIT model by jackrua · Pull Request #137 · pgvector/pgvector-python · GitHub
Skip to content

Add other input types for SQLAlchemy BIT model #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackrua wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add other input types for SQLAlchemy BIT model #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
05349f9
feat: add method to read from database and make method to write to da…
jackrua Jul 17, 2025
2b5e53d
feat: add processor methods to BIT class
jackrua Jul 17, 2025
45cc2e1
test: use string directly instead of BitString
jackrua Jul 17, 2025
3d14b22
fix: fix for case when value is none
jackrua Jul 17, 2025
33e265c
Merge branch 'master' into feature/other_inputs_for_sqlalchemy_bit
jackrua Sep 8, 2025
1411240
feat: add other input types for bit
jackrua Sep 22, 2025
f176041
fix: test
jackrua Sep 22, 2025
c48f0d2
fix: use correct engine url
jackrua Sep 22, 2025
2e6795d
fix: add user back into engine url
jackrua Sep 22, 2025
d786125
style: remove unused method
jackrua Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pgvector/bit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,12 @@ def from_binary(cls, value):

@classmethod
def _to_db(cls, value):
if value is None:
return value

if not isinstance(value, cls):
raise ValueError('expected bit')

value = cls(value)
return value.to_text()

@classmethod
Expand Down
6 changes: 4 additions & 2 deletions pgvector/sqlalchemy/bit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import asyncpg
from sqlalchemy.dialects.postgresql.asyncpg import PGDialect_asyncpg
from sqlalchemy.dialects.postgresql.base import ischema_names
from sqlalchemy.types import UserDefinedType, Float

from .. import Bit

class BIT(UserDefinedType):
cache_ok = True
Expand All @@ -24,7 +26,7 @@ def process(value):
return value
return process
else:
return super().bind_processor(dialect)
return lambda value: Bit._to_db(value)

class comparator_factory(UserDefinedType.Comparator):
def hamming_distance(self, other):
Expand Down
8 changes: 7 additions & 1 deletion tests/test_sqlalchemy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,13 @@ def test_bit(self, engine):
item = session.get(Item, 1)
assert item.binary_embedding == '101'

def test_boolean_list_bit(self, engine):
with Session(engine) as session:
session.add(Item(id=1, binary_embedding=[True, False, True]))
session.commit()
item = session.get(Item, 1)
assert item.binary_embedding == '101'

def test_bit_hamming_distance(self, engine):
create_items()
with Session(engine) as session:
Expand Down Expand Up @@ -567,7 +574,6 @@ def test_halfvec_array(self, engine):
item = session.get(Item, 1)
assert item.half_embeddings == [HalfVector([1, 2, 3]), HalfVector([4, 5, 6])]


@pytest.mark.parametrize('engine', async_engines)
class TestSqlalchemyAsync:
def setup_method(self):
Expand Down