Repository navigation
Allow custom PHP code in the real-time benchmark workflow - #24189
Open
LamentXU123 wants to merge 1 commit into
Open
LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a real-time benchmark workflow which can benchmark the difference before and after a PR to measure performance improvements. However, Most of the performance PR focus on a specific function. Those PRs produce little difference in huge frameworks' benchmark (and often arguably within noise) The idea of this PR is to add a feature to the workflow (or expose a already exist feature from kocsismate/php-version-benchmarks@d29cbb9) which allows us to run custom code in real-time benchmark of a PR.
Let's say a PR claims to improve performance of
str_contains. Than we can runin that workflow to see real-time benchmark results to check the improvments.
If the custom_code field is empty, than we go back to the original real-time workflow. Only maintainers with push permittions are able to run this workflow.