Visitar URL original
Set custom webdriver port with ENV var and checking port availability by usernameComputer01 · Pull Request #1124 · php-webdriver/php-webdriver · GitHub
Skip to content

Set custom webdriver port with ENV var and checking port availability - #1124

Open
usernameComputer01 wants to merge 3 commits into
php-webdriver:mainfrom
usernameComputer01:main
Open

Set custom webdriver port with ENV var and checking port availability#1124
usernameComputer01 wants to merge 3 commits into
php-webdriver:mainfrom
usernameComputer01:main

Conversation

@usernameComputer01

@usernameComputer01 usernameComputer01 commented Mar 28, 2025

Copy link
Copy Markdown 
Chrome: WEBDRIVER_CHROME_CUSTOM_PORT
Firefox: WEBDRIVER_FIREFOX_CUSTOM_PORT

@usernameComputer01
Set custom webdriver port with ENV var
3fc6650 
    Chrome: WEBDRIVER_CHROME_CUSTOM_PORT
    Firefox: WEBDRIVER_FIREFOX_CUSTOM_PORT
@williamdes

williamdes commented Mar 28, 2025

Copy link
Copy Markdown
Collaborator

Does such env exist in another project ?
could we use more standard ones ?

@usernameComputer01

usernameComputer01 commented Mar 28, 2025

Copy link
Copy Markdown
Author

Does such env exist in another project ? could we use more standard ones ?

I didn't find any information on the ENV standard for webdriver.

@usernameComputer01
usernameComputer01 force-pushed the main branch 2 times, most recently from b893e92 to 153a1ad Compare March 28, 2025 12:22
@usernameComputer01 usernameComputer01 changed the title Set custom webdriver port with ENV var Set custom webdriver port with ENV var and checking port availability Mar 28, 2025
@usernameComputer01

usernameComputer01 commented Mar 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Added checking for availability of listening port

williamdes
williamdes reviewed Mar 31, 2025
View reviewed changes
Comment thread composer.json Resolved
williamdes
williamdes reviewed Mar 31, 2025
View reviewed changes
Comment thread lib/Remote/Service/DriverService.php Resolved
@usernameComputer01 @williamdes
Update lib/Remote/Service/DriverService.php
ee06ecb 
Co-authored-by: William Desportes <williamdes@wdes.fr>
williamdes
williamdes approved these changes Oct 1, 2025
View reviewed changes

@williamdes williamdes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, @OndraM ?

OndraM
OndraM requested changes Dec 16, 2025
View reviewed changes

@OndraM OndraM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please update the sockets dependency? 🙏

Comment thread composer.json Resolved
Comment thread lib/Remote/Service/DriverService.php
/**
* @throws RuntimeException
*/
protected static function checkPortIsAvail(int $port)

@OndraM OndraM Dec 16, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected static function checkPortIsAvail(int $port)
protected static function checkPortIsAvailable(int $port)

No need for shortcuts :)

Comment thread lib/Remote/Service/DriverService.php
*/
protected static function checkPortIsAvail(int $port)
{
$errTest = static function ($sock) use ($port) {

@OndraM OndraM Dec 16, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should check if the Sockets extension is enabled, and if not, it should just return true (ie. the same behavior as before - without free port detection).

@OndraM OndraM added the waiting for reaction Further information/reaction is requested label Jan 31, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OndraM OndraM OndraM requested changes
+1 more reviewer
@williamdes williamdes williamdes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for reaction Further information/reaction is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@usernameComputer01 @williamdes @OndraM