Visitar URL original
Use first-class callables in sorting functions by kamil-tekiela · Pull Request #18855 · phpmyadmin/phpmyadmin · GitHub
Skip to content

Use first-class callables in sorting functions - #18855

Merged
MauricioFauth merged 2 commits into
phpmyadmin:masterfrom
kamil-tekiela:strnatcasecmp
Dec 19, 2023
Merged

MauricioFauth merged 2 commits into
phpmyadmin:masterfrom
kamil-tekiela:strnatcasecmp

Conversation

@kamil-tekiela

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@codecov

codecov Bot commented Dec 19, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f3be6ef) 56.94% compared to head (5ec43f7) 56.94%.

Files Patch % Lines
src/ConfigStorage/Relation.php 0.00% 2 Missing ⚠️
src/Controllers/Table/RelationController.php 66.66% 1 Missing ⚠️
src/DatabaseInterface.php 66.66% 1 Missing ⚠️
src/ListDatabase.php 0.00% 1 Missing ⚠️
src/Util.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #18855   +/-   ##
=========================================
  Coverage     56.94%   56.94%           
  Complexity    16083    16083           
=========================================
  Files           676      676           
  Lines         63808    63808           
=========================================
  Hits          36334    36334           
  Misses        27474    27474           
Flag Coverage Δ
dbase-extension 56.94% <60.00%> (ø)
unit-8.1-ubuntu-latest 56.90% <60.00%> (ø)
unit-8.2-ubuntu-latest 56.87% <60.00%> (ø)
unit-8.3-ubuntu-latest 56.87% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MauricioFauth
MauricioFauth merged commit 961b339 into phpmyadmin:master Dec 19, 2023
@MauricioFauth MauricioFauth self-assigned this Dec 19, 2023
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Dec 19, 2023
@kamil-tekiela
kamil-tekiela deleted the strnatcasecmp branch December 19, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants