Visitar URL original
Fix broken views by kamil-tekiela · Pull Request #20582 · phpmyadmin/phpmyadmin · GitHub
Skip to content

Fix broken views - #20582

Open
kamil-tekiela wants to merge 2 commits into
phpmyadmin:masterfrom
kamil-tekiela:Fix-broken-views
Open

kamil-tekiela wants to merge 2 commits into
phpmyadmin:masterfrom
kamil-tekiela:Fix-broken-views

Conversation

@kamil-tekiela

Copy link
Copy Markdown
Contributor

When a view has an error, in 5.2 you could still open its structure page. Additionally, we need to show the error message when it happens.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.81%. Comparing base (f42a612) to head (67d2f8b).
⚠️ Report is 8776 commits behind head on master.

Files with missing lines Patch % Lines
src/Sql.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #20582       +/-   ##
=============================================
+ Coverage     50.49%   64.81%   +14.31%     
+ Complexity    17267    16050     -1217     
=============================================
  Files           607      681       +74     
  Lines         68348    57569    -10779     
=============================================
+ Hits          34510    37311     +2801     
+ Misses        33838    20258    -13580     
Flag Coverage Δ
dbase-extension 64.75% <87.50%> (+14.44%) ⬆️
guzzlehttp/psr7-psr-7 ?
laminas/laminas-diactoros-psr-7 ?
nyholm/psr7-psr-7 ?
recode-extension ?
slim/psr7-psr-7 ?
unit-7.2 ?
unit-7.3 ?
unit-7.4 ?
unit-8.0 ?
unit-8.1 ?
unit-8.2 64.76% <87.50%> (+15.23%) ⬆️
unit-8.3 64.77% <87.50%> (+15.22%) ⬆️
unit-8.4 64.77% <87.50%> (+13.91%) ⬆️
unit-8.5 64.77% <87.50%> (+13.91%) ⬆️
unit-8.6 64.69% <87.50%> (+15.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant