Repository navigation
Conversation
Default to an empty string when the maxsize parameter is not sent with the export request. Signed-off-by: HawkForge <75696486+HawkForge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an export request is submitted without the
maxsizeparameter ("Skip tables larger than"),Export::exportDatabase()reads$GLOBALS['maxsize'], which was never set, becauseExportControlleronly copies POST parameters that are present into the globals. On PHP 8.1+ this triggers "Undefined global variable $maxsize" (reported at https://reports.phpmyadmin.net/incidents/view/2969944).This defaults the value to an empty string, which the existing check already treats as "no size limit". A regression test is added to
ExportTest.Fixes #20525
Signed-off-byline as described in our DCO.Replaces #20526, which got closed when my fork was accidentally detached.