Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Prunes dead SASS and consolidates exact duplicates across the editor, code editor, launch and error stylesheets, with no intended visual change.
editor.csscode-editor.csserror.csslaunch.cssui-*attribute rules, rules for removed panels, dead state classes, and selectors that Sass@extendwove into impossible combinations (e.g..font-iconwoven into ~400 selectors)error.scssno longer imports the whole PCUI theme; it keeps the few values and the scrollbar rules the static error pages usepcui/_pcui-core.scss(theme and tooltip only) instead of every editor-only PCUI extension_editor-tokens.scssspin-360andskeleton-pulse_editor-mcp.scssand folds_editor-scene-size-alert.scssinto_editor-toolbar-alert.scss; deletes the empty_editor-settings-ai.scssVerification: every change was checked with a cascade-aware comparison of the compiled CSS against
main, and by swapping the old and new stylesheet into the running editor and diffing the computed style of every element (plus::before/::after) and a screenshot. That covered the projects page, the idle editor, every entity and asset inspector in a sample project, scene settings, the color, version control, builds, project and team pickers, the code editor with a script open, the launch page and an error page. All showed zero differing styles.Rules that never matched but look like they were meant to (removed as-is, worth a follow-up fix):
.script-asset-inspector-attribute-warning.clickable-warning: clickable script warnings never got the pointer/underline.pcui-menu-item-postfix.disabled: PCUI usespcui-disabled, so the disabled paste label was never hidden.cms-card-desc.empty,.dev-log-post-actions { gap: 2px }: same value as, or overridden by, the parent ruleManual smoke test:
Checks