Visitar URL original
Fixed an incorrect path in the phantomjs run_tests.js wrapper. by samgreen · Pull Request #5 · playcanvas/engine · GitHub
Skip to content

Fixed an incorrect path in the phantomjs run_tests.js wrapper. - #5

Merged
daredevildave merged 1 commit into
masterfrom
unknown repository
Jul 30, 2014
Merged

daredevildave merged 1 commit into
masterfrom
unknown repository

Conversation

@samgreen

@samgreen samgreen commented Jun 6, 2014

Copy link
Copy Markdown
Contributor

Paths were updated and the tests script was failing. We should also get some documentation regarding how to setup and run the phantomjs unit tests.

@daredevildave

Copy link
Copy Markdown
Contributor

Hmm, I'd forgotten we actually had phantomjs tests. They've been sadly neglected as I could never get them working in a headless way.

We currently run tests manually by loading all_tests.html in a browser.

daredevildave added a commit that referenced this pull request Jul 30, 2014
Fixed an incorrect path in the phantomjs run_tests.js wrapper.
@daredevildave
daredevildave merged commit a6dd208 into playcanvas:master Jul 30, 2014
willeastcott pushed a commit that referenced this pull request Oct 17, 2014
raytranuk added a commit that referenced this pull request Dec 21, 2020
restore LIGHTTYPE_POINT and make LIGHTTYPE_OMNI private for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants