Visitar URL original
fix: Show the internal before-passes and the camera use of engine 2.24 passes by mvaligursky · Pull Request #17 · playcanvas/inspector · GitHub
Skip to content

fix: Show the internal before-passes and the camera use of engine 2.24 passes - #17

Merged
mvaligursky merged 2 commits into
mainfrom
mv-frame-graph-internal-passes
Oct 27, 2026
Merged

mvaligursky merged 2 commits into
mainfrom
mv-frame-graph-internal-passes

Conversation

@mvaligursky

@mvaligursky mvaligursky commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Engine 2.24 moved parts of the frame graph the Frame Graph view reads, so parts of the view went missing. The view now reads both engine shapes, so it keeps working with earlier engines.

Changes:

Fixes #13

…4 passes

The frame graph view nests the internal before-passes of a pass under it, ahead of its
before-passes, and reads the first and last camera use of a forward pass from the pass,
where engine 2.24 keeps them. Earlier engines, which have neither, keep working, and the
requires cubemaps row is only shown on engines which still have the property.

Fixed #13
@mvaligursky mvaligursky self-assigned this Oct 27, 2026
…ce tab

The internal before-passes of a pass are what the frame needs ahead of it,
such as the directional shadows of a forward pass. The Frame graph tab nests
them under the pass, but the Performance tab now leaves them out when it
looks for effects, so a forward pass is not grouped with its shadows as an
effect and they stay passes of their own.
@mvaligursky
mvaligursky merged commit 187e181 into main Oct 27, 2026
3 checks passed
@mvaligursky
mvaligursky deleted the mv-frame-graph-internal-passes branch October 27, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frame graph view misses the internal before-passes and the camera use flags of forward passes

1 participant