Visitar URL original
Fix numeric and numeric-string marker symbol variant detection in `scattergl` by Lexachoc · Pull Request #8071 · plotly/plotly.js · GitHub
Skip to content

Fix numeric and numeric-string marker symbol variant detection in scattergl - #8071

Open
Lexachoc wants to merge 4 commits into
plotly:mainfrom
Lexachoc:fix-scattergl-marker-symbol-display
Open

Fix numeric and numeric-string marker symbol variant detection in scattergl#8071
Lexachoc wants to merge 4 commits into
plotly:mainfrom
Lexachoc:fix-scattergl-marker-symbol-display

Conversation

@Lexachoc

@Lexachoc Lexachoc commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Closes #8070

Fix marker variant detection in scattergl for numeric (100, 200, and 300) and numeric-string ('100', '200' and '300') symbol values.

This PR makes numeric (numeric-string) symbol representations behave consistently with their named equivalents for scattergl and all WebGL-based traces that reuse its marker handling.

@Lexachoc Lexachoc changed the title Fix numeric marker variant detection issue in scattergl Fix numeric and numeric-string marker symbol variant detection in scattergl Sep 23, 2026
@Lexachoc
Lexachoc marked this pull request as draft September 24, 2026 09:40
@Lexachoc
Lexachoc marked this pull request as ready for review September 24, 2026 09:40
@Lexachoc

Lexachoc commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

I think there was an issue with GitHub yesterday that caused many of the checks to fail. However, I can't seem to find an option to re-run the failed checks.

camdecoster
camdecoster requested changes Sep 25, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Your update solves the problem. When I was reviewing, I found a helper function that could simplify this a bit. Let me know what you think.

Could you please add a unit test that covers these functions?

Comment thread src/traces/scattergl/helpers.js Outdated
Comment thread src/traces/scattergl/helpers.js Outdated
Comment thread src/traces/scattergl/helpers.js Outdated
@camdecoster camdecoster self-assigned this Sep 25, 2026
@Lexachoc

Lexachoc commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

I applied your suggestion and added unit tests for the marker symbol detection.

@Lexachoc
Lexachoc requested a review from camdecoster October 6, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster Awaiting requested review from camdecoster

Requested changes must be addressed to merge this pull request.

Assignees

@camdecoster camdecoster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: scattergl incorrectly handles numeric and numeric-string marker variants

2 participants

@Lexachoc @camdecoster