Visitar URL original
improve julia language support by ericphanson · Pull Request #3494 · pre-commit/pre-commit · GitHub
Skip to content

improve julia language support #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericphanson wants to merge 8 commits into from
Closed

improve julia language support #3494

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7f8efa
improve julia support
ericphanson Jul 21, 2025
9583b19
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 21, 2025
0c54b47
make flake and mypy happier
ericphanson Jul 21, 2025
5501721
add
ericphanson Jul 21, 2025
ae6f19d
add test for julia version support
ericphanson Jul 21, 2025
f2837cf
add channel
ericphanson Jul 21, 2025
9a04b39
copy rust's pattern for conditional env
ericphanson Jul 21, 2025
1ba5581
restore comment
ericphanson Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Jul 21, 2025
commit 9583b19216c66af72518ae84067d9f0fe55cc4ee
7 changes: 5 additions & 2 deletions pre_commit/languages/julia.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,24 @@ def run_hook(
color=color,
)


def get_env_patch(target_dir: str, version: str) -> PatchesT:
patches = [
('JULIA_LOAD_PATH', target_dir),
('JULIA_PROJECT', UNSET),
]
if version not in ("system", "default"):
if version not in ('system', 'default'):
patches.append(('JULIAUP_CHANNEL', version))

@asottile asottile Jul 21, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't quite right. to properly support language_version pre-commit must install the language itself into the hook environment (and not outside of it such as in the juliaup managed directories)

@ericphanson ericphanson Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, pre-commit wants an entire copy of julia installed into the hook environment directory? that's very unusual for julia, which uses content-addressed read-only files and packages to allow reuse across environments. It would also make pre-commit install much slower for julia hooks than it currently is.

return tuple(patches)


@contextlib.contextmanager
def in_env(prefix: Prefix, version: str) -> Generator[None]:
envdir = lang_base.environment_dir(prefix, ENVIRONMENT_DIR, version)
with envcontext(get_env_patch(envdir, version)):
yield


def install_environment(
prefix: Prefix,
version: str,
Expand Down Expand Up @@ -95,7 +98,7 @@ def install_environment(
break

# copy `src` files if they exist
src_dir = prefix.path("src")
src_dir = prefix.path('src')
if os.path.isdir(src_dir):
shutil.copytree(src_dir, os.path.join(envdir, 'src'))

Expand Down