Visitar URL original
Do not split call of scss function with leading dash by auvred · Pull Request #15370 · prettier/prettier · GitHub
Skip to content

Do not split call of scss function with leading dash - #15370

Merged
sosukesuzuki merged 7 commits into
prettier:mainfrom
auvred:fix/15369
Sep 13, 2023
Merged

sosukesuzuki merged 7 commits into
prettier:mainfrom
auvred:fix/15369

Conversation

@auvred

@auvred auvred commented Sep 8, 2023 •

Copy link
Copy Markdown
Contributor

Description

Fixes #15369

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker

This comment was marked as outdated.

@fisker

This comment was marked as outdated.

@fisker

This comment was marked as outdated.

Comment thread tests/format/scss/scss/scss.scss Resolved

@fisker fisker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Comment thread tests/format/scss/scss/scss.scss Resolved
@sosukesuzuki
sosukesuzuki merged commit 7c51265 into prettier:main Sep 13, 2023
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 16, 2024
* Do not split call of scss function with leading dash

* add changelog

* apply check only for scss parser

* Revert "apply check only for scss parser"

This reverts commit 378bf1a.

* add more test cases

* use test case from original issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested SCSS function calls with leading dash are interpreted as unary minus

3 participants