Visitar URL original
Note the Codex Override in the Codex Host-Safety README by ptr727 · Pull Request #4093 · ptr727/ProjectTemplate · GitHub
Skip to content

Note the Codex Override in the Codex Host-Safety README - #4093

Merged
ptr727 merged 3 commits into
developfrom
feature/codex-readme-override
Nov 12, 2026
Merged

ptr727 merged 3 commits into
developfrom
feature/codex-readme-override

Conversation

@ptr727

@ptr727 ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Summary

Answers the attested local review of the develop -> main promotion, #4088, at 20b8392.

host-setup/agent-safety/codex/README.md said the host-wide rules reach Codex through AGENTS.md without qualification. Since #4092, a non-blank AGENTS.override.md takes precedence, which the status reports as SHADOWED and not current. The README now says so, matching docs/host-setup.md and the update-host skill.

The prose gate is clean, and a recorded local pass found nothing open.

🤖 Generated with Claude Code

The README said the host-wide rules reach Codex through AGENTS.md without qualification. A
non-blank AGENTS.override.md takes precedence, which the status reports as SHADOWED.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 12, 2026 08:06
@ptr727

ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 37bab7a30f095b020cad97970ed874222fb9a0de, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active documentation inconsistency remains: the README claims fleet rules are the only behavioral layer without limiting that statement to cases where no non-blank override exists.

1 open issue
What changed in this PR

Updates the Codex host-safety README to document how a non-blank AGENTS.override.md takes precedence over AGENTS.md and shadows host-wide rules.

Changes:

  • Documents override precedence and the resulting SHADOWED and not-current status.
  • Aligns the README with the global rules implementation and related host-setup guidance.
  • Notes that the behavioral-layer claim should be scoped to the unshadowed case.
File Description
host-setup/​agent-safety/​codex/​README.md Documents Codex override precedence, shadowed status reporting, and the resulting host-wide rule behavior.

Review effort: Lite

Comment thread host-setup/agent-safety/codex/README.md Resolved
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (20b8392) to head (6a69988).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4093   +/-   ##
========================================
  Coverage    76.73%   76.73%           
========================================
  Files           40       40           
  Lines        14104    14104           
========================================
  Hits         10822    10822           
  Misses        3282     3282           
Flag Coverage Δ
python-3.13 76.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ptr727 and others added 2 commits November 12, 2026 00:18
A non-blank AGENTS.override.md is itself a Codex instruction layer, so the fleet's rules are
the fleet's only behavioral layer, and an override replaces the host-wide rules' place.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Placed between the layer claim and "They include GOVERNANCE.md", the sentence made "They" read
as the rules the override replaces, when the carried repository rules still apply.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 6a69988f49c0b5bfcb6e0dc2260d4782463fa52c, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727
ptr727 merged commit 8e19057 into develop Nov 12, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/codex-readme-override branch November 12, 2026 08:35
ptr727 added a commit that referenced this pull request Nov 12, 2026
…kill (#4088)

## Summary

Promotes one change and its review follow-ups from `develop` to `main`.

- #4087: one action brings a host fully current for every coding agent,
and both host menus run it from a single line.
- `bootstrap.sh --agent-setup` / `bootstrap.ps1 -AgentSetup` runs four
steps in order. It upgrades the coding-agent CLIs already installed,
installs the fleet skills, and installs the Claude Code safety kit. It
then writes the host-wide rule blocks into Codex's and opencode's global
`AGENTS.md`, for each agent present.
- `--agent-status` reports all four read-only, and `--host` and `--dev`
now end with the agent setup.
  - A new `update-host` skill runs the setup from any session.
- The kit's stamp names the resolved commit when installed from a
bootstrap tree, which fixes items 2 and 3 of #2553. Item 1 of #2553,
installing the Claude Code CLI itself, stays open. Hooks for Codex and
opencode stay on #781.

- #4089: answers CodeRabbit's review of this promotion. The Windows
skill commands run the loader only after its download succeeds. The
status summary reports the agent-tools inventory as listed, failed or
not checked rather than current. `bootstrap.ps1` restores the
source-commit variables after a run, and `--agent-status --from-tree` no
longer needs curl, tar or flock. The rules wrappers prefer Python 3.11+.
Two findings were declined with evidence on their threads.

- #4090: the host-setup README's tree-lifetime paragraph no longer
counts the tree-keeping actions, and scopes itself to a run that fetches
its tree.
- #4091: the fleet map's G1 entry and cold-start flowchart describe the
agent setup. The README and the flowchart say the Claude Code plugin
registration, the safety kit and the host-wide rules act only on agents
already installed. So a fresh machine re-runs the agent setup after
installing a coding agent, before its first session. The
`install-skills` and `install-safety-kit` headers state where each
wrapper reaches.

- #4092: answers this promotion's attested local review. The Codex and
opencode rules files carry a digest of the rules written below their
header and note. A hand edit there now reads EDITED and is backed up
before the next rewrite. A non-blank Codex `AGENTS.override.md` makes
the status report SHADOWED and not current, and the setup never touches
it. Two findings from that review were declined with evidence: sharing
the skills installer's commit lookup, and the Python-less report.

- #4093: the Codex host-safety README says a non-blank
`AGENTS.override.md` keeps the host-wide rules from reaching Codex, and
takes their place as its instruction layer.

## Not Verified

- Native Windows end to end, a `verification` gap. Native Windows CI ran
the unit suite, including the new `global_rules.py` tests, and passed.
`bootstrap.ps1 -AgentSetup` / `-AgentStatus`, the Windows wrappers, tar
extraction and the user-profile writes have not run on a real Windows
host. Their PowerShell logic was exercised only through the
lifted-function tests under `pwsh`.

Refs #2553

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants