Visitar URL original
State the Shared SDK Step's Checkout Order Plainly in Its Test by ptr727 · Pull Request #4127 · ptr727/ProjectTemplate · GitHub
Skip to content

State the Shared SDK Step's Checkout Order Plainly in Its Test - #4127

Merged
ptr727 merged 2 commits into
developfrom
promotion-4126-fixes
Nov 13, 2026
Merged

State the Shared SDK Step's Checkout Order Plainly in Its Test#4127
ptr727 merged 2 commits into
developfrom
promotion-4126-fixes

Conversation

@ptr727

@ptr727 ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Summary

Answers a Copilot finding on the develop -> main promotion #4126. The comment above the shared SDK step's ordering assertion in tests/test_release_guards.py said "a step ahead of the checkout installs the fallback", which the reviewer read as the opposite of the order the assertion enforces. It now says the dotnet-sdk step must follow the checkout, and that run before it, the step finds no global.json and installs the fallback line.

The other finding on that round, on host-setup/windows/install-agents.ps1:766, needs no change. It is answered on #4126 with a constructed case.

Verification

  • test_release_guards.DotnetSdkLineCase passes.
  • The local strict review over this diff raised no finding.

🤖 Generated with Claude Code

@ptr727 @claude
State the Shared SDK Step's Checkout Order Plainly in Its Test
ac451cf 
The comment above the ordering assertion now says the shared dotnet-sdk
step must follow the checkout, and what running it before does, where its
"ahead of" wording read as the opposite order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 13, 2026 01:54
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ptr727 ptr727 added the comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses label Nov 13, 2026
@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head ac451cffa7d8cefba1372adf122e4137688a3343, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI reviewed Nov 13, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A remaining P2 nit in the release-guard test comment uses ambiguous pronouns and unclear action ordering, so the wording should be clarified before approval.

1 open issue
What changed in this PR

This pull request clarifies the checkout-order rationale in the shared .NET SDK guard test without changing its assertions or behavior.

Changes:

  • States that the shared SDK action must run after checkout.
  • Explains that running the action before checkout selects the fallback SDK line.
  • Records one remaining documentation nit about ambiguous wording.
File Description
tests/​test_release_guards.py Clarifies why the shared SDK action must follow checkout in the workflow ordering test.

Review effort: Lite

Comment thread tests/test_release_guards.py Resolved
@codecov

codecov Bot commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.69%. Comparing base (b9f70b3) to head (1824df3).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #4127   +/-   ##
========================================
  Coverage    76.69%   76.69%           
========================================
  Files           40       40           
  Lines        14146    14146           
========================================
  Hits         10849    10849           
  Misses        3297     3297
Flag Coverage Δ
python-3.13 76.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Action not completed

Head commit changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727 @claude
Name the Action and the Checkout in the Ordering Comment
1824df3 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 1824df316601be317b783ff9fdec353aaad7a772, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727
ptr727 merged commit 7c3b7ee into develop Nov 13, 2026
13 checks passed
@ptr727
ptr727 deleted the promotion-4126-fixes branch November 13, 2026 02:23
@ptr727 ptr727 mentioned this pull request Nov 13, 2026
Merged
ptr727 added a commit that referenced this pull request Nov 13, 2026
@ptr727
Promote Develop: the Fleet .NET SDK Line on Hosts and in CI (#4126)
dbe09c0 
## Summary

Promotes the .NET SDK line work and two changes from other hub sessions
from `develop` to `main`.

- #4110:
- The Linux host installer's default dotnet set is the fleet's SDK line
plus the newest line the feed carries, so a host whose feed has moved
past 10.0 still builds fleet .NET repositories.
- Each installer names the line itself (`DOTNET_FLEET_LINE` on Linux,
`$DOTNET_MAJOR` on Windows) so it still runs fetched on its own, and a
test holds both to the `global.json` baseline.
- The hub's setup-dotnet steps go through a new
`.github/actions/dotnet-sdk`, which installs the line the caller's
`global.json` selects. It falls back to `10.x` for a caller carrying no
`sdk.version` yet.
- #4127: the shared SDK step's ordering comment states the required
order plainly, answering a Copilot finding on this promotion.
- #4129: the `dotnet-sdk` action reads `global.json` as the dotnet host
and setup-dotnet do, so a commented file selects its line, answering a
Copilot finding on this promotion.
- #4130: a `global.json` whose `sdk` is null gets the fallback line, as
the dotnet host treats it, answering a Copilot thread on this promotion.
- #4116: the agent setup runs past a failed tool upgrade, and a held
`cswap` is skipped.
- #4125: `carry.py` carries a registry entry not yet promoted to `main`
when run from a `develop` checkout.

Closes #4106
Closes #4107

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727