Visitar URL original
fix django commands hack. now django doesn't require specific overrid… by davidleon · Pull Request #3153 · pyinstaller/pyinstaller · GitHub
Skip to content

fix django commands hack. now django doesn't require specific overrid… - #3153

Open
davidleon wants to merge 2 commits into
pyinstaller:developfrom
davidleon:develop
Open

davidleon wants to merge 2 commits into
pyinstaller:developfrom
davidleon:develop

Conversation

@davidleon

Copy link
Copy Markdown

…e commands hook. django staticfiles runserver should properly run. and test against django 2.0

…e commands hook. django staticfiles runserver should properly run. and test against django 2.0
@ghost

ghost commented Dec 23, 2017

Copy link
Copy Markdown

This doesn't appear to work on Python 2.7, which unfortunately is still the majority of our user base.

… app should load correctly. original fix doesn't load admin app correctly
@davidleon

Copy link
Copy Markdown
Author

new to python maybe someone can help to alter the code to be python2 and 3 compatible? not sure why it's not working in python 2.7

@ghost

ghost commented Dec 25, 2017

Copy link
Copy Markdown

Almost there. Rerun this command and iterate until it passes. Then I'll help you clean this up.

[in PyInstaller directory]
pip install -e .
pytest tests/functional/test_hooks/test_django.py::test_django[onedir]

@htgoebel htgoebel closed this Mar 15, 2018
@htgoebel htgoebel reopened this Mar 15, 2018
@htgoebel htgoebel added the area:hooks Caused by or effecting some hook label Mar 15, 2018
@Legorooj
Legorooj force-pushed the develop branch 4 times, most recently from 3a8eccd to e20e74c Compare April 17, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:hooks Caused by or effecting some hook

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants