Visitar URL original
switch to modulegraph 2 by xoviat · Pull Request #5808 · pyinstaller/pyinstaller · GitHub
Skip to content

switch to modulegraph 2 - #5808

Draft
xoviat wants to merge 174 commits into
pyinstaller:developfrom
xoviat:modulegraph2
Draft

xoviat wants to merge 174 commits into
pyinstaller:developfrom
xoviat:modulegraph2

Conversation

@xoviat

@xoviat xoviat commented May 6, 2021 •

Copy link
Copy Markdown
Contributor

this is a draft PR to see what it would take to switch to modulegraph2

tracking #5812

This adds tests for names available as public symbols
in the modulegraph2 namespace.

This also removes all incomplete and untested symbols
from the public API (will be added back when I'm
happy about the implementation)
Including full tests. The code doesn't use ast.NodeVisitor to avoid
running out of stack space.
The tests have 100% test coverage according to coverage.py,
but I haven't checked yet if there is sufficent testing.
One thing I don't quite like is a spurious return statement that's
needed to keep coverage.py happy.
I'm not happy about the naming in modulegraph._depproc, and
the global function '_process_namelist' (this should be a method
given its close interaction with ModuleGraph)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants