Visitar URL original
Use os.path.commonpath() instead of commonprefix() by sethmlarson · Pull Request #222 · pypa/pyproject-hooks · GitHub
Skip to content

Use os.path.commonpath() instead of commonprefix() - #222

Merged
takluyver merged 1 commit into
pypa:mainfrom
sethmlarson:patch-2
Feb 18, 2026
Merged

takluyver merged 1 commit into
pypa:mainfrom
sethmlarson:patch-2

Conversation

@sethmlarson

Copy link
Copy Markdown
Contributor

Now that pyproject-hooks supports only Python 3.6+ commonprefix() is no longer required.

@takluyver
takluyver merged commit 8b1fe0a into pypa:main Feb 18, 2026
21 checks passed
@takluyver

Copy link
Copy Markdown
Member

Thanks @sethmlarson!

@jaraco

jaraco commented Jul 12, 2026 •

Copy link
Copy Markdown
Member

Would be nice to see a release of this. Because it's unreleased and it's breaking Setuptools' test suite, we'll have to suppress the warning until a release is cut (and then remove the suppression later).

(to be fair, Setuptools' own warnings-as-errors setting is also implicated)

@jaraco

jaraco commented Jul 12, 2026

Copy link
Copy Markdown
Member

Closes #221 and #223

@notatallshaw

Copy link
Copy Markdown
Member

FWIW, we found this switch created a breaking regression on pip: python/cpython#149444 / pypa/pip#14001

And the solution in the pip PR has a regression, that no one has reported yet, where / incorrectly can't be selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants