Visitar URL original
Add method to set the History TTL by ColinShark · Pull Request #681 · pyrogram/pyrogram · GitHub
Skip to content
This repository was archived by the owner on Dec 23, 2024. It is now read-only.

Add method to set the History TTL - #681

Open
ColinShark wants to merge 6 commits into
pyrogram:masterfrom
ColinShark:history-ttl
Open

Add method to set the History TTL#681
ColinShark wants to merge 6 commits into
pyrogram:masterfrom
ColinShark:history-ttl

Conversation

@ColinShark

@ColinShark ColinShark commented May 13, 2021

Copy link
Copy Markdown
Contributor

app.set_history_ttl(chat_id, period) to automatically delete messages after either a day (86400) or a week (604800). 0 to disable.

@ColinShark
Add method to set the History TTL
31c5b91 
`app.set_history_ttl(chat_id, period)` to automatically delete messages
after either a day or a week. 0 to disable.
delivrance
delivrance suggested changes May 14, 2021
View reviewed changes
Comment thread pyrogram/methods/chats/set_history_ttl.py Resolved
Comment thread pyrogram/methods/chats/set_history_ttl.py Resolved
Comment thread pyrogram/methods/chats/set_history_ttl.py Resolved
Comment thread pyrogram/types/messages_and_media/message.py Resolved
Comment thread pyrogram/types/messages_and_media/message.py Resolved
@delivrance

delivrance commented May 14, 2021

Copy link
Copy Markdown
Member

I'm also not fully convinced about keeping "TTL" in the convenience API, but at the moment I can't think of a better and short enough replacement.

ColinShark and others added 5 commits May 14, 2021 17:55
delivrance
delivrance reviewed May 15, 2021
View reviewed changes
Comment thread pyrogram/types/messages_and_media/message.py
elif isinstance(action, raw.types.MessageActionInviteToGroupCall):
voice_chat_members_invited = types.VoiceChatMembersInvited._parse(client, action, users)
service_type = "voice_chat_members_invited"
elif isinstance(action, raw.types.MessageActionSetMessagesTTL):

@delivrance delivrance May 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this made me think that maybe we should rename the whole thing to set_chat_messages_ttl or just set_chat_ttl since the feature applies to new messages not to the whole history (or can be seen as a global chat setting regardless of messages or history). What do you think? There's also a ttl_period field for messages (see the raw Message object) which I guess it will be set for all new messages when ttl is enabled.

@delivrance delivrance May 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, set_chat_ttl(), Chat.set_ttl(), Message.chat_ttl_period.

@AkkiaS7 AkkiaS7 mentioned this pull request Jan 3, 2024
Open

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@delivrance delivrance delivrance requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ColinShark @delivrance