Repository navigation
Warn on impossible-to-match message pattern in filterwarnings - #15364
Open
giovanamalaia wants to merge 1 commit into
Open
giovanamalaia wants to merge 1 commit into
giovanamalaia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #10478 by warning users when they configure a
filterwarningsmessage containing an unescaped empty regex group(). Users often write()expecting it to match literal parentheses (e.g.,ignore:The foo.bar() function is deprecated), but since the message is interpreted as a regular expression, it behaves as an empty group and silently fails to match the literal text.What I changed
_has_empty_regex_groupinsrc/_pytest/config/__init__.pyto safely detect unescaped()outside of character classes._warn_on_empty_regex_groupto emit aPytestConfigWarningwhenescape=False, guiding the user to escape the parentheses (\(\)) or usere.escape().TestEmptyGroupInFilterMessage) intesting/test_warnings.pyvalidating true positives (e.g.,()) and true negatives (e.g.,[()],\(\),foo(bar),foo(a|)).changelog/10478.improvement.rst) and updatedAUTHORS.AI Assistance
Closes #10478