Repository navigation
test_import.test_concurrency leaks ref on Windows #106176
Description
Activity
This leak can be seen on the "AMD64 Windows11 Refleaks 3.12" buildbot for example: https://buildbot.python.org/all/#/builders/1103/builds/36
I reproduced it locally.
Reacted by Giangpro89Reacted by Giangpro89On Python 3.12, test_import.test_concurrency() leaks on Windows:
Did you mean that this test leaks only on 3.12?
I can still reproduce it on current main branch (3.13).More info
./python -m test test_import -m test_concurrency -R 3:3 Running debug|x64 interpreter... 0:00:00 Run tests sequentially 0:00:00 [1/1] test_import beginning 6 repetitions 123456 ...... test_import leaked [40, 40, 40] references, sum=120 test_import leaked [40, 40, 40] memory blocks, sum=120 test_import failed (reference leak) == Tests result: FAILURE == 1 test failed: test_import Total duration: 7.0 sec Tests result: FAILURE
Did you mean that this test leaks only on 3.12?
No. It also affects 3.12
Reacted by Kirill PodoprigoraI'm not familiar with the leak checking system and I'm not likely to have much time to learn about it in the foreseeable future.
- added a commit that references this issue
on Jun 28, 2023 @exarkun it just means some things are not getting cleaned up.
Just trying to signal my likelihood of pitching on here: low.
Oops, I just reported a duplicate of this bug: #107086 (closed).
I also found the same commit with git bisect: commit 3325f05
commit 3325f054e33b318aa56b74472f76a56b8afc0510 Author: Jean-Paul Calderone <exarkun@twistedmatrix.com> Date: Fri Jan 20 19:00:39 2023 -0500 gh-91351: Fix some bugs in importlib handling of re-entrant imports (GH-94504) Co-authored-by: Brett Cannon <brett@python.org>@Yhg1s: IMO, this is also a release blocker (in my opinion, any ref leak is a release blocker).
(Yes, this looks like a real leak, not an artifact of how the refleak checker reruns things, so it should be a release blocker.)
Reacted by Erlend E. Aasland and sunmy2019We could revert the fix that leads to the leak to unblock the release as I'm not sure if anyone has come up with a good solution to avoid the memory leak and the bugs that get fixed are not fundamental to import (although it would still be nice to have the bugs fixed).
Reacted by Erlend E. Aasland- moved this from Todo to Done in Release and Deferred blockers 🚫
on Aug 29, 2023
On Python 3.12,
test_import.test_concurrency()leaks on Windows:bisected to #94504
Potentially Related: #104702
See #102251 (comment) #104796 (comment)
Linked PRs