Visitar URL original
gh-99941: asyncio.Protocol.data_received now received immutable bytes by DarioDaF · Pull Request #100053 · python/cpython · GitHub
Skip to content

gh-99941: asyncio.Protocol.data_received now received immutable bytes #100053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 4 commits into from
Dec 10, 2022
Merged

gh-99941: asyncio.Protocol.data_received now received immutable bytes #100053

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aad3337
Moving transport data_read to bytes through memoryview
DarioDaF Dec 6, 2022
1a5af35
Added test case for #99941
DarioDaF Dec 6, 2022
d9e22f7
Added blurb
DarioDaF Dec 6, 2022
e101911
Simplify news entry
gvanrossum Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added test case for #99941
  • Loading branch information
@DarioDaF
DarioDaF committed Dec 6, 2022
commit 1a5af35f3667d5961869662e08f882fe9c3f0e95
5 changes: 4 additions & 1 deletion Lib/test/test_asyncio/test_proactor_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ def test_loop_reading_data(self):
called_buf = bytearray(self.buffer_size)
called_buf[:len(buf)] = buf
self.loop._proactor.recv_into.assert_called_with(self.sock, called_buf)
self.protocol.data_received.assert_called_with(bytearray(buf))
self.protocol.data_received.assert_called_with(buf)
# assert_called_with maps bytearray and bytes to the same thing so check manually
# regression test for https://github.com/python/cpython/issues/99941
self.assertIsInstance(self.protocol.data_received.call_args.args[0], bytes)

@unittest.skipIf(sys.flags.optimize, "Assertions are disabled in optimized mode")
def test_loop_reading_no_data(self):
Expand Down