Visitar URL original
gh-100143: Improve collecting pystats for parts of runs by mdboom · Pull Request #100144 · python/cpython · GitHub
Skip to content

gh-100143: Improve collecting pystats for parts of runs #100144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 7 commits into from
Dec 12, 2022
Merged

gh-100143: Improve collecting pystats for parts of runs #100144

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
153e33e
pystats off by default
mdboom Dec 9, 2022
63eb983
Add -Xpystats flag
mdboom Dec 9, 2022
fcabb09
Always dump pystats, even if turned off
mdboom Dec 9, 2022
66facd6
Fix division-by-zero errors in summarize_stats.py
mdboom Dec 9, 2022
73af144
Add blurb
mdboom Dec 9, 2022
07dcbad
Update Misc/NEWS.d/next/Core and Builtins/2022-12-09-14-27-36.gh-issu…
mdboom Dec 12, 2022
efa0bb6
Merge branch 'main' into fix-pystats
mdboom Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add -Xpystats flag
  • Loading branch information
@mdboom
mdboom committed Dec 9, 2022
commit 63eb98304e4de5bb0e84a527781ffaf46d97edba
15 changes: 14 additions & 1 deletion Python/initconfig.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,14 @@ The following implementation-specific options are available:\n\
\n\
-X int_max_str_digits=number: limit the size of int<->str conversions.\n\
This helps avoid denial of service attacks when parsing untrusted data.\n\
The default is sys.int_info.default_max_str_digits. 0 disables.";
The default is sys.int_info.default_max_str_digits. 0 disables."

#ifdef Py_STATS
"\n\
\n\
-X pystats: Enable pystats collection at startup."
#endif
;

/* Envvars that don't have equivalent command-line options are listed first */
static const char usage_envvars[] =
Expand Down Expand Up @@ -2188,6 +2195,12 @@ config_read(PyConfig *config, int compute_path_config)
config->show_ref_count = 1;
}

#ifdef Py_STATS
if (config_get_xoption(config, L"pystats")) {
_py_stats = &_py_stats_struct;
}
#endif

status = config_read_complex_options(config);
if (_PyStatus_EXCEPTION(status)) {
return status;
Expand Down