Visitar URL original
gh-99110: Initialize frame->previous in init_frame to fix segmentation fault by byllyfish · Pull Request #100182 · python/cpython · GitHub
Skip to content

gh-99110: Initialize frame->previous in init_frame to fix segmentation fault #100182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 10 commits into from
Dec 23, 2022
Merged

gh-99110: Initialize frame->previous in init_frame to fix segmentation fault #100182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b2e7256
Initialize frame->previous in _PyFrame_InitializeSpecials.
byllyfish Dec 12, 2022
b6e290d
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 12, 2022
f667d8f
Fixing Python file whitespace. (patchcheck)
byllyfish Dec 12, 2022
d679783
Move initialization of frame->previous to init_frame.
byllyfish Dec 13, 2022
230b80e
Move comment above function.
byllyfish Dec 18, 2022
4e70dc5
Add frame_new function to _testcapimodule.c.
byllyfish Dec 18, 2022
627e8d5
Remove blank line.
byllyfish Dec 18, 2022
35a4c58
Use assertIsNone
kumaraditya303 Dec 23, 2022
34bee72
Merge branch 'main' into fix-issue-99110
kumaraditya303 Dec 23, 2022
2c1db99
Update Misc/NEWS.d/next/Core and Builtins/2022-12-12-01-05-16.gh-issu…
kumaraditya303 Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Initialize frame->previous in _PyFrame_InitializeSpecials.
  • Loading branch information
@byllyfish
byllyfish committed Dec 12, 2022
commit b2e72562707b5724917f59ffae6a5dd3931a086d
1 change: 1 addition & 0 deletions Include/internal/pycore_frame.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ _PyFrame_InitializeSpecials(
frame->f_locals = locals;
frame->stacktop = code->co_nlocalsplus;
frame->frame_obj = NULL;
frame->previous = NULL;
frame->prev_instr = _PyCode_CODE(code) - 1;
frame->yield_offset = 0;
frame->owner = FRAME_OWNED_BY_THREAD;
Expand Down
31 changes: 31 additions & 0 deletions Lib/test/test_ctypes/test_python_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,5 +81,36 @@ def test_pyobject_repr(self):
self.assertEqual(repr(py_object(42)), "py_object(42)")
self.assertEqual(repr(py_object(object)), "py_object(%r)" % object)

def test_PyFrame_New_f_back(self):
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
"""Test that accessing `f_back` does not cause a segmentation fault on
a frame created with ctypes (GH-99110)."""
# Adapted from:
# https://naleraphael.github.io/blog/posts/devlog_create_a_builtin_frame_object/

p_memtype = POINTER(c_ulong if sizeof(c_void_p) == 8 else c_uint)
pythonapi.PyFrame_New.argtypes = (
p_memtype, # PyThreadState *tstate
p_memtype, # PyCodeObject *code
py_object, # PyObject *globals
py_object # PyObject *locals
)
pythonapi.PyFrame_New.restype = py_object # PyFrameObject*
pythonapi.PyThreadState_Get.argtypes = None
pythonapi.PyThreadState_Get.restype = p_memtype

def dummy():
pass

frame = pythonapi.PyFrame_New(
pythonapi.PyThreadState_Get(), # thread state
cast(id(dummy.__code__), p_memtype), # a code object
globals(),
locals(),
)

# The following line should not cause a segmentation fault.
assert frame.f_back is None
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated


if __name__ == "__main__":
unittest.main()