Visitar URL original
gh-100268: Add is_integer method to int by hauntsaninja · Pull Request #100439 · python/cpython · GitHub
Skip to content

gh-100268: Add is_integer method to int #100439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 5 commits into from
Dec 24, 2022
Merged

gh-100268: Add is_integer method to int #100439

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
930121e
gh-100268: Add is_integer method to int
hauntsaninja Dec 22, 2022
fdf6bbd
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 22, 2022
0d2dfa9
docs
hauntsaninja Dec 22, 2022
d5f67e1
mention float in docs
hauntsaninja Dec 23, 2022
6b0a02e
update __doc__
hauntsaninja Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Doc/library/stdtypes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,12 @@ class`. In addition, it provides a few more methods:

.. versionadded:: 3.8

.. method:: int.is_integer()

Returns ``True``.
Comment thread
hauntsaninja marked this conversation as resolved.
Outdated

.. versionadded:: 3.12

Additional Methods on Float
---------------------------

Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test_long.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,6 +1553,11 @@ def test_from_bytes_small(self):
b = i.to_bytes(2, signed=True)
self.assertIs(int.from_bytes(b, signed=True), i)

def test_is_integer(self):
self.assertTrue((-1).is_integer())
self.assertTrue((0).is_integer())
self.assertTrue((1).is_integer())

def test_access_to_nonexistent_digit_0(self):
# http://bugs.python.org/issue14630: A bug in _PyLong_Copy meant that
# ob_digit[0] was being incorrectly accessed for instances of a
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-12-22-21-56-08.gh-issue-100268.xw_phB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add :meth:`int.is_integer` to improve duck type compatibility between :class:`int` and :class:`float`.
20 changes: 19 additions & 1 deletion Objects/clinic/longobject.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6168,6 +6168,19 @@ long_long_meth(PyObject *self, PyObject *Py_UNUSED(ignored))
return long_long(self);
}

/*[clinic input]
int.is_integer

Returns True.
Comment thread
hauntsaninja marked this conversation as resolved.
Outdated
[clinic start generated code]*/

static PyObject *
int_is_integer_impl(PyObject *self)
/*[clinic end generated code: output=90f8e794ce5430ef input=5987f0abb5d0e177]*/
{
Py_RETURN_TRUE;
}

static PyMethodDef long_methods[] = {
{"conjugate", long_long_meth, METH_NOARGS,
"Returns self, the complex conjugate of any int."},
Expand All @@ -6186,6 +6199,7 @@ static PyMethodDef long_methods[] = {
INT___GETNEWARGS___METHODDEF
INT___FORMAT___METHODDEF
INT___SIZEOF___METHODDEF
INT_IS_INTEGER_METHODDEF
{NULL, NULL} /* sentinel */
};

Expand Down