Visitar URL original
GH-84559: Deprecate fork being the multiprocessing default. by gpshead · Pull Request #100618 · python/cpython · GitHub
Skip to content

GH-84559: Deprecate fork being the multiprocessing default. #100618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 23 commits into from
Feb 2, 2023
Merged

GH-84559: Deprecate fork being the multiprocessing default. #100618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
1cecbdb
GH-84559: Deprecate fork being the multiprocessing default.
gpshead Dec 30, 2022
df83fba
address CI test failures?
gpshead Dec 31, 2022
ec1e868
the new warning needs no pickle name mapping
gpshead Dec 31, 2022
a1064de
avoid DeprecationWarnings vs -Werror
gpshead Dec 31, 2022
223b748
prefer forkserver over fork for concurrent.futures
gpshead Dec 31, 2022
fc64626
explicitly use spawn for simple process launchers.
gpshead Dec 31, 2022
e45fab6
warn from concurrent.futures, reword things.
gpshead Dec 31, 2022
29764a2
avoid double warning in futures
gpshead Dec 31, 2022
c52b9db
Cleanup messages, test futures warning.
gpshead Dec 31, 2022
4c8cc34
cleanup warn stacklevel logic
gpshead Dec 31, 2022
7179684
Document all the things!
gpshead Dec 31, 2022
f7e3161
Have all doctests use 'spawn'.
gpshead Jan 1, 2023
9947860
Correct warning stacklevel for Manager.
gpshead Jan 1, 2023
5834f2d
more doctest cleanup.
gpshead Jan 1, 2023
7d48e86
NEWS entry.
gpshead Jan 1, 2023
28c0cfc
docs: add the implicit i
gpshead Jan 10, 2023
2820bb8
Merge branch 'main' into multiprocessing/deprecate-fork-default
gpshead Jan 28, 2023
4c16205
Use skip_file_prefixes.
gpshead Jan 28, 2023
7d84a72
use the modern warnings API, doc updates.
gpshead Jan 28, 2023
8b2029e
documentation cleanup
gpshead Jan 28, 2023
846e9a0
Remove an unused variable.
gpshead Feb 1, 2023
7078986
doc typo fix, unnecessary method change revert.
gpshead Feb 1, 2023
e3e3b3c
Add What's New entries.
gpshead Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
avoid DeprecationWarnings vs -Werror
  • Loading branch information
@gpshead
gpshead committed Dec 31, 2022
commit a1064dee146334e77641a39fa6cb3b868badd15f
1 change: 1 addition & 0 deletions Lib/test/_test_venv_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def test_func():


def main():
multiprocessing.set_start_method('spawn')
test_pool = multiprocessing.Process(target=test_func)
test_pool.start()
test_pool.join()
Expand Down
9 changes: 8 additions & 1 deletion Lib/test/test_asyncio/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import concurrent.futures
import functools
import io
import multiprocessing
import os
import platform
import re
Expand Down Expand Up @@ -2696,7 +2697,13 @@ def test_get_event_loop_new_process(self):
support.skip_if_broken_multiprocessing_synchronize()

async def main():
pool = concurrent.futures.ProcessPoolExecutor()
if multiprocessing.get_start_method() == 'fork':
# Avoid 'fork' DeprecationWarning.
mp_context = multiprocessing.get_context('forkserver')
else:
mp_context = None
pool = concurrent.futures.ProcessPoolExecutor(
mp_context=mp_context)
result = await self.loop.run_in_executor(
pool, _test_get_event_loop_new_process__sub_proc)
pool.shutdown()
Expand Down