Visitar URL original
gh-100933: Improve `check_element` helper in `test_xml_etree` by sobolevn · Pull Request #100934 · python/cpython · GitHub
Skip to content

gh-100933: Improve check_element helper in test_xml_etree #100934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 1 commit into from
Feb 8, 2023
Merged

gh-100933: Improve check_element helper in test_xml_etree #100934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-100933: Improve check_element helper in test_xml_etree
  • Loading branch information
@sobolevn
sobolevn committed Jan 11, 2023
commit a11b4035f81785beb0de91fe38fc28b838e1e41e
27 changes: 4 additions & 23 deletions Lib/test/test_xml_etree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,25 +203,6 @@ def serialize_check(self, elem, expected):
def test_interface(self):
# Test element tree interface.

def check_string(string):
len(string)
for char in string:
self.assertEqual(len(char), 1,
msg="expected one-character string, got %r" % char)
new_string = string + ""
new_string = string + " "
string[:0]

def check_mapping(mapping):
len(mapping)
keys = mapping.keys()
items = mapping.items()
for key in keys:
item = mapping[key]
mapping["key"] = "value"
self.assertEqual(mapping["key"], "value",
msg="expected value string, got %r" % mapping["key"])

def check_element(element):
self.assertTrue(ET.iselement(element), msg="not an element")
direlem = dir(element)
Expand All @@ -231,12 +212,12 @@ def check_element(element):
self.assertIn(attr, direlem,
msg='no %s visible by dir' % attr)

check_string(element.tag)
check_mapping(element.attrib)
self.assertIsInstance(element.tag, str)
self.assertIsInstance(element.attrib, dict)
if element.text is not None:
check_string(element.text)
self.assertIsInstance(element.text, str)
if element.tail is not None:
check_string(element.tail)
self.assertIsInstance(element.tail, str)
for elem in element:
check_element(elem)

Expand Down