Visitar URL original
gh-76961: Possible fix for buildbot failures in test_pep3118 by mdickinson · Pull Request #101587 · python/cpython · GitHub
Skip to content

gh-76961: Possible fix for buildbot failures in test_pep3118 #101587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 5 commits into from
Feb 6, 2023
Merged

gh-76961: Possible fix for buildbot failures in test_pep3118 #101587

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3586c09
Possible fix for buildbot failures in test_pep3118
mdickinson Feb 5, 2023
aed7122
Use uint instead of uint32
mdickinson Feb 5, 2023
1222418
Suppress warnings from -Wsign-compare
mdickinson Feb 5, 2023
f273e74
Silence Wunused-variable via the time-honoured solution of casting to…
mdickinson Feb 5, 2023
59144e7
One more try: replace 'I' with s_uint
mdickinson Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Silence Wunused-variable via the time-honoured solution of casting to… 
… void
  • Loading branch information
@mdickinson
mdickinson committed Feb 5, 2023
commit f273e74c3bf2e74e2ddaf4de4149d02ec851ef9b
2 changes: 1 addition & 1 deletion Modules/_ctypes/stgdict.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ _ctypes_alloc_format_padding(const char *prefix, Py_ssize_t padding)
return _ctypes_alloc_format_string(prefix, "x");
}

int ret = PyOS_snprintf(buf, sizeof(buf), "%zdx", padding);
int ret = PyOS_snprintf(buf, sizeof(buf), "%zdx", padding); (void)ret;

@mdickinson mdickinson Feb 5, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the (void)ret; trick comes from the LLVM Coding Standard: https://llvm.org/docs/CodingStandards.html#assert-liberally

assert(0 <= ret && ret < (Py_ssize_t)sizeof(buf));
return _ctypes_alloc_format_string(prefix, buf);
}
Expand Down