Visitar URL original
[3.9] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) by miss-islington · Pull Request #101709 · python/cpython · GitHub
Skip to content

[3.9] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) - #101709

Merged
ambv merged 2 commits into
python:3.9from
miss-islington:backport-23751ed-3.9
Feb 9, 2023
Merged

[3.9] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286)#101709
ambv merged 2 commits into
python:3.9from
miss-islington:backport-23751ed-3.9

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 8, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin oleg@arhadthedev.net

@arhadthedev @miss-islington
pythongh-101283: Improved fallback logic for subprocess with shell=Tr…
fccaea3 
…ue on Windows (pythonGH-101286)

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
This was referenced Feb 8, 2023
Closed
Merged
@bedevere-bot bedevere-bot added the type-security A security issue label Feb 8, 2023
zooba
zooba reviewed Feb 8, 2023
View reviewed changes
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Lib/subprocess.py
@miss-islington

miss-islington commented Feb 8, 2023

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@arhadthedev
arhadthedev marked this pull request as draft February 9, 2023 03:39
@arhadthedev

arhadthedev commented Feb 9, 2023

Copy link
Copy Markdown
Member

Undrafting since the introduced bug will be fixed separately by backports of gh-101712. My apologizes for the confusion; I didn't sort out my incoming notifications timely.

@arhadthedev
arhadthedev marked this pull request as ready for review February 9, 2023 06:14
@ambv
ambv merged commit 04cc427 into python:3.9 Feb 9, 2023
@miss-islington
miss-islington deleted the backport-23751ed-3.9 branch February 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @arhadthedev @zooba @ambv @bedevere-bot